Add VP9 to chrome_webrtc_perf_browsertest.cc.

Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG=chromium:554512
Committed: https://crrev.com/21146ff8f2f067aefb441419caff542d3097cb05
Cr-Commit-Position: refs/heads/master@{#379537}

[asapersson2, 2016-03-02 11:23:15]

Patchset #1 (id:1) has been deleted

[asapersson2, 2016-03-02 11:23:26]

Patchset #1 (id:20001) has been deleted

[asapersson2, 2016-03-03 09:49:17]

Patchset #1 (id:40001) has been deleted

[asapersson2, 2016-03-03 09:53:10]

Description was changed from

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

BUG=chromium:554512
==========

to

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

BUG=chromium:554512
==========

[asapersson2, 2016-03-03 09:53:11]

asapersson@chromium.org changed reviewers:
+ phoglund@chromium.org

[asapersson2, 2016-03-03 11:47:51]

Patchset #1 (id:60001) has been deleted

[phoglund_chromium, 2016-03-05 17:05:45]

No issues with the implementation, but are you sure you need tests for all
permutations? This means we're going from

60 sec A/V
60 sec 1-way A/V

to

60-sec A/V VP8
60-sec A/V VP9
60-sec A/V Default
60-sec 1-way A/V VP8
60-sec 1-way A/V VP9
60-sec 1-way A/V Default

This triples execution time since these tests need to execute sequentially, and
massively increases the number of metrics the sheriff needs to keep track of. I
know "Default" are going away so I guess we can live with that.

Would it be enough to just do the 1-way call for default and strike out the VP8-
and VP9-specific versions? Discuss with Stefan; I know the 1-way tests did find
some RTT bugs in the past, so maybe you really do need those.

[asapersson2, 2016-03-07 09:53:03]

Description was changed from

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

BUG=chromium:554512
==========

to

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG=chromium:554512
==========

[asapersson2, 2016-03-07 09:57:09]

On 2016/03/05 17:05:45, phoglund_chrome_ooo_to_mar_7 wrote:
> No issues with the implementation, but are you sure you need tests for all
> permutations? This means we're going from
> 
> 60 sec A/V
> 60 sec 1-way A/V
> 
> to
> 
> 60-sec A/V VP8
> 60-sec A/V VP9
> 60-sec A/V Default
> 60-sec 1-way A/V VP8
> 60-sec 1-way A/V VP9
> 60-sec 1-way A/V Default
> 
> This triples execution time since these tests need to execute sequentially,
and
> massively increases the number of metrics the sheriff needs to keep track of.
I
> know "Default" are going away so I guess we can live with that.
> 
> Would it be enough to just do the 1-way call for default and strike out the
VP8-
> and VP9-specific versions? Discuss with Stefan; I know the 1-way tests did
find
> some RTT bugs in the past, so maybe you really do need those.

Ok, I have removed the VP8 and VP9 specific versions to the one-way test for
now.

[phoglund_chromium, 2016-03-07 10:39:44]

Cool! Set a reminder in your calendar to follow up and remove the default
two-way test in, say, two weeks.

lgtm

[asapersson2, 2016-03-07 10:47:07]

The CQ bit was checked by asapersson@chromium.org

[commit-bot: I haz the power, 2016-03-07 10:47:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755073002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755073002/100001

[commit-bot: I haz the power, 2016-03-07 11:19:49]

Description was changed from

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG=chromium:554512
==========

to

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG=chromium:554512
==========

[commit-bot: I haz the power, 2016-03-07 11:19:50]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-03-07 11:21:14]

Description was changed from

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG=chromium:554512
==========

to

==========
Add VP9 to chrome_webrtc_perf_browsertest.cc.

60 sec audio-video call ->

60 sec audio-video call VP8
60 sec audio-video call VP9
60 sec audio-video call Default

BUG=chromium:554512

Committed: https://crrev.com/21146ff8f2f067aefb441419caff542d3097cb05
Cr-Commit-Position: refs/heads/master@{#379537}
==========

[commit-bot: I haz the power, 2016-03-07 11:21:15]

Patchset 2 (id:??) landed as
https://crrev.com/21146ff8f2f067aefb441419caff542d3097cb05
Cr-Commit-Position: refs/heads/master@{#379537}