Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 1755053002: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 813821256dcae6235f3b1e927f02ff223bb06cf8..f66c1f4b069b7769488a49c278e8fb3b9cc7439e 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -941,7 +941,11 @@ PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
s.BindInt(11, form.type);
s.BindString16(12, form.display_name);
s.BindString(13, form.icon_url.spec());
- s.BindString(14, form.federation_origin.Serialize());
+ // We serialize unique origins as "", in order to make other systems that
+ // read from the login database happy. https://crbug.com/591310
+ s.BindString(14, form.federation_origin.unique()
+ ? ""
vasilii 2016/03/02 11:45:00 std::string()
+ : form.federation_origin.Serialize());
s.BindInt(15, form.skip_zero_click);
s.BindInt(16, form.generation_upload_status);

Powered by Google App Engine
This is Rietveld 408576698