tools/dom/scripts/dartgenerator.py - Issue 17550014: Fixing up previous CL to fix Dartium issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/dartgenerator.py

Issue 17550014: Fixing up previous CL to fix Dartium issues. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/dartgenerator.py

diff --git a/tools/dom/scripts/dartgenerator.py b/tools/dom/scripts/dartgenerator.py

index 4f6de3ae71cbf8239e7b51862eb312cc28efadfc..8635eff719db6b0f94df2dca1726caad902ea343 100755

--- a/tools/dom/scripts/dartgenerator.py

+++ b/tools/dom/scripts/dartgenerator.py

@@ -85,7 +85,10 @@ class DartGenerator(object):

if (type_name is not None and

self._IsCompoundType(database, type_name)):

continue

- _logger.warn('removing %s in %s which has unidentified type %s' %

+ # Ignore constructor warnings.

+ if not (interface.id in ['DOMWindow', 'WorkerContext'] and

+ type_name.endswith('Constructor')):

+ _logger.warn('removing %s in %s which has unidentified type %s' %

(node_name, interface.id, type_name))

return False

return True