Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17550010: Move IDL implements statements to IDL files that implement the interface (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, pdr, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, haraken, Stephen Chennney, Nate Chapin, do-not-use, lgombos
Visibility:
Public.

Description

Move IDL implements statements to IDL files that implement the interface Move IDL implements statements to IDL files that implement the interface so that we can more easily know that a given IDL interface implements another. The generator now enforces this as well for consistency. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -62 lines) Patch
M Source/bindings/scripts/preprocess_idls.py View 4 chunks +18 lines, -10 lines 0 comments Download
M Source/core/dom/CharacterData.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ChildNode.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentFragment.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentType.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/ParentNode.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGCircleElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGCursorElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGDefsElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGExternalResourcesRequired.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGradientElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGImageElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLineElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGMPathElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGMaskElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPatternElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPolylineElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGRectElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGScriptElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTRefElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTests.idl View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGURIReference.idl View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/svg/SVGUseElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGViewElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/workers/AbstractWorker.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-21 16:22:02 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 6 months ago (2013-06-21 16:26:59 UTC) #2
haraken
LGTM
7 years, 6 months ago (2013-06-21 16:28:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17550010/1
7 years, 6 months ago (2013-06-21 16:33:16 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 18:02:39 UTC) #5
Message was sent while issue was closed. 
Change committed as 152893

Powered by Google App Engine
This is Rietveld 408576698