Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: cc/layers/scrollbar_layer.h

Issue 17550008: Make IsSolidColor() a property on CC scrollbar layers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Jochen's comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/scrollbar_layer.h
diff --git a/cc/layers/scrollbar_layer.h b/cc/layers/scrollbar_layer.h
index a6c4a01b1380e6419552e1ccf8a26737eb530395..60cc040d566052ed3c6d913add6d89dfdda5537a 100644
--- a/cc/layers/scrollbar_layer.h
+++ b/cc/layers/scrollbar_layer.h
@@ -23,7 +23,8 @@ class CC_EXPORT ScrollbarLayer : public ContentsScalingLayer {
static scoped_refptr<ScrollbarLayer> Create(
scoped_ptr<Scrollbar> scrollbar,
- int scroll_layer_id);
+ int scroll_layer_id,
+ bool is_solid_color);
jamesr 2013/07/03 21:26:24 this being a bool makes callsites really hard to r
int scroll_layer_id() const { return scroll_layer_id_; }
void SetScrollLayerId(int id);
@@ -31,6 +32,7 @@ class CC_EXPORT ScrollbarLayer : public ContentsScalingLayer {
virtual bool OpacityCanAnimateOnImplThread() const OVERRIDE;
ScrollbarOrientation Orientation() const;
+ bool is_solid_color() const { return is_solid_color_; }
// Layer interface
virtual void SetTexturePriorities(const PriorityCalculator& priority_calc)
@@ -51,7 +53,8 @@ class CC_EXPORT ScrollbarLayer : public ContentsScalingLayer {
protected:
ScrollbarLayer(scoped_ptr<Scrollbar> scrollbar,
- int scroll_layer_id);
+ int scroll_layer_id,
+ bool is_solid_color);
virtual ~ScrollbarLayer();
private:
@@ -74,6 +77,7 @@ class CC_EXPORT ScrollbarLayer : public ContentsScalingLayer {
int thumb_length_;
gfx::Rect track_rect_;
int scroll_layer_id_;
+ bool is_solid_color_;
unsigned texture_format_;

Powered by Google App Engine
This is Rietveld 408576698