Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 17550008: Make IsSolidColor() a property on CC scrollbar layers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use DCHECK(layer_tree_host()) instead. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 30616268f2053ee494aad578457546f0fa88c2d5..31604cd047ae036568d12a24383391caf28c7830 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -223,7 +223,12 @@ void LayerTreeImpl::UpdateMaxScrollOffset() {
}
void LayerTreeImpl::UpdateSolidColorScrollbars() {
- DCHECK(settings().solid_color_scrollbars);
+ // FIXME: This logic will need to change when we re-factor RootScrollLayer()
enne (OOO) 2013/06/26 17:39:05 FIXME => TODO(wjmaclean)
wjmaclean 2013/06/26 18:16:00 Done.
+ // into InnerViewportScrollLayer() and OuterViewportScrollLayer(), since in
+ // the desktop case the OuterViewportScrollLayer() won't have solid color
+ // scrollbars, while the InnerViewportScrollLayer() will. Ultimately, the
+ // plan is for this function to disappear altogether.
+ DCHECK(settings().force_solid_color_scrollbars);
LayerImpl* root_scroll = RootScrollLayer();
DCHECK(root_scroll);
@@ -252,7 +257,7 @@ void LayerTreeImpl::UpdateDrawProperties() {
if (IsActiveTree() && RootScrollLayer() && RootClipLayer())
UpdateRootScrollLayerSizeDelta();
- if (settings().solid_color_scrollbars &&
+ if (settings().force_solid_color_scrollbars &&
IsActiveTree() &&
RootScrollLayer()) {
UpdateSolidColorScrollbars();

Powered by Google App Engine
This is Rietveld 408576698