Make IsSolidColor() a property on CC scrollbar layers.

cc/base/switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/base/switches.h"
 
 #include "base/command_line.h"
 
 namespace cc {
 namespace switches {
@@ skipping 113 matching lines @@
 // Enable the codepath that uses images within TileManager.
 const char kUseMapImage[] = "use-map-image";
 
 // Prevents the layer tree unit tests from timing out.
 const char kCCLayerTreeTestNoTimeout[] = "cc-layer-tree-test-no-timeout";
 
 // Trace events get dumped to stderr for debugging purposes.
 const char kCCUnittestsTraceEventsToVLOG[] =
     "cc-unittests-trace-events-to-vlog";
 
+// Allow forcing of solid-color scrollbars

[jamesr, 2013/07/03 21:26:24]

what does it mean to "allow forcing"?  Does the flag force solid color
scrollbars on or not?

+const char kForceSolidColorScrollbars[] = "force-solid-color-scrollbars";
+
+// Solid-color scrollbar color in hex ARGB format, e.g. 0x80808080.
+// The 0x/0X prefix is optional.
+const char kSolidColorScrollbarColor[] = "solid-color-scrollbar-color";
+
+// Solid-color scrollbar thickness in DIP.
+const char kSolidColorScrollbarThickness[] = "solid-color-scrollbar-thickness";
+
+bool ForceSolidColorScrollbars() {

[jamesr, 2013/07/03 21:26:24]

the function name looks like it's doing something, not querying a value. can you
come up with a name that reads better? i expect typically calling code to look
like

if (Something()) { .... }

so you want the function name to make that line read naturally as

"if solid color scrollbars are forced on then ...."

as is, the line would be

if (ForceSolidColorScrollbars()) { .... }

which looks like the body of the if() is causing something to happen, not
querying a value

+  return CommandLine::ForCurrentProcess()->HasSwitch(
+      cc::switches::kForceSolidColorScrollbars);
+}
+
 bool IsImplSidePaintingEnabled() {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
 
   if (command_line.HasSwitch(cc::switches::kDisableImplSidePainting))
     return false;
   else if (command_line.HasSwitch(cc::switches::kEnableImplSidePainting))
     return true;
 
 #if defined(OS_ANDROID)
   return true;
 #else
   return false;
 #endif
 }
 
 }  // namespace switches
 }  // namespace cc