Make IsSolidColor() a property on CC scrollbar layers.

content/renderer/gpu/render_widget_compositor.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/render_widget_compositor.h"
 
 #include <limits>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 59 matching lines @@
   } else {
     LOG(WARNING) << "Failed to parse switch " << switch_string  << ": " <<
         string_value;
     return false;
   }
 }
 
 
 }  // namespace
 
+static bool StringToSkColor(const std::string& str, SkColor& color) {

[jochen (gone - plz use gerrit), 2013/06/30 08:13:07]

nit. move into the anonymous namespace instead of making this static

[wjmaclean, 2013/07/02 13:50:31]

Done.

+  std::string prefix = str.substr(0,2);
+  int offset = (prefix == "0x" || prefix == "0X") ? 2 : 0;
+
+  std::vector<uint8> values;
+  if (base::HexStringToBytes(str.substr(offset), &values)) {
+    if (values.size() != 4)
+      return false;
+
+    color = SkColorSetARGB(values[0], values[1], values[2], values[3]);
+    return true;
+  }
+
+  return false;
+}
+
 // static
 scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create(
       RenderWidget* widget) {
   scoped_ptr<RenderWidgetCompositor> compositor(
       new RenderWidgetCompositor(widget));
 
   CommandLine* cmd = CommandLine::ForCurrentProcess();
 
   cc::LayerTreeSettings settings;
 
@@ skipping 174 matching lines @@
   settings.strict_layer_property_change_checking =
       cmd->HasSwitch(cc::switches::kStrictLayerPropertyChangeChecking);
 
   settings.use_map_image = cmd->HasSwitch(cc::switches::kUseMapImage);
 
 #if defined(OS_ANDROID)
   // TODO(danakj): Move these to the android code.
   settings.can_use_lcd_text = false;
   settings.max_partial_texture_updates = 0;
   settings.use_linear_fade_scrollbar_animator = true;
-  settings.solid_color_scrollbars = true;
-  settings.solid_color_scrollbar_color = SkColorSetARGB(128, 128, 128, 128);
-  settings.solid_color_scrollbar_thickness_dip = 3;
   settings.highp_threshold_min = 2048;
 #endif
 
+  if (cmd->HasSwitch(cc::switches::kForceSolidColorScrollbars))
+    settings.force_solid_color_scrollbars = true;
+
+  if (cmd->HasSwitch(cc::switches::kSolidColorScrollbarThickness)) {
+    std::string str =
+        cmd->GetSwitchValueASCII(cc::switches::kSolidColorScrollbarThickness);
+    int thickness;
+    if (base::StringToInt(str, &thickness))

[jochen (gone - plz use gerrit), 2013/06/30 08:13:07]

what happens if the thickness is negative or zero?

[wjmaclean, 2013/07/02 13:50:31]

Done.

Change so that if the user enters a negative thickness, they get the default
value for thickness (i.e. as if the flag was never specified).

+      settings.solid_color_scrollbar_thickness_dip = thickness;
+  }
+
+  if (cmd->HasSwitch(cc::switches::kSolidColorScrollbarColor)) {
+    std::string str =
+        cmd->GetSwitchValueASCII(cc::switches::kSolidColorScrollbarColor);
+
+    SkColor scrollbar_color;
+    if (StringToSkColor(str, scrollbar_color))
+      settings.solid_color_scrollbar_color = scrollbar_color;
+  }
+
   if (!compositor->initialize(settings))
     return scoped_ptr<RenderWidgetCompositor>();
 
   return compositor.Pass();
 }
 
 RenderWidgetCompositor::RenderWidgetCompositor(RenderWidget* widget)
   : suppress_schedule_composite_(false),
     widget_(widget) {
 }
@@ skipping 269 matching lines @@
   return RenderThreadImpl::current()->OffscreenContextProviderForMainThread();
 }
 
 scoped_refptr<cc::ContextProvider>
 RenderWidgetCompositor::OffscreenContextProviderForCompositorThread() {
   return RenderThreadImpl::current()->
       OffscreenContextProviderForCompositorThread();
 }
 
 }  // namespace content