Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 17550005: Distinguish times_8 and times_pointer_size usage for X64 (Closed)

Created:
7 years, 6 months ago by haitao.feng
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Distinguish times_8 and times_pointer_size for X64 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/x64/codegen-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Times_8 is equal to times_pointer_size for X64. But for X32 times_pointer_size is times_4. It is ...
7 years, 6 months ago (2013-06-21 12:50:40 UTC) #1
Jakob Kummerow
LGTM. I'll land this.
7 years, 6 months ago (2013-06-21 12:55:13 UTC) #2
Jakob Kummerow
7 years, 6 months ago (2013-06-21 12:57:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698