Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 1754963003: Add trailing slash to virtual fast/hidpi/static tests for rebaseline. (Closed)

Created:
4 years, 9 months ago by wkorman
Modified:
4 years, 9 months ago
Reviewers:
oshima
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trailing slash to virtual fast/hidpi/static tests for rebaseline. The Blink rebaseline bot canonicalizes entries representing a directory to terminate with a path separator in TestExpectationParser._collect_matching_tests(). However, in AutoRebaseline.get_test_prefix_list() we check test presence in a test prefix list (obtained via TestExpectations.get_needs_rebaseline_failures()), and the test used as the key is non-canonicalized. A more long term fix is to ensure we canonicalize the test before checking for presence, but in interim manually specifying the directories needing rebaseline to include the expected path separator should allow the tests to be rebaselined properly. BUG=577300, 485650 TBR=oshima Committed: https://crrev.com/a4bc1bd8b475f778491e682cc29411f56d00cfa0 Cr-Commit-Position: refs/heads/master@{#378905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754963003/1
4 years, 9 months ago (2016-03-03 00:20:19 UTC) #3
wkorman
4 years, 9 months ago (2016-03-03 00:21:55 UTC) #5
oshima
lgtm thanks for fixing this!
4 years, 9 months ago (2016-03-03 00:37:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 01:29:04 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:30:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4bc1bd8b475f778491e682cc29411f56d00cfa0
Cr-Commit-Position: refs/heads/master@{#378905}

Powered by Google App Engine
This is Rietveld 408576698