Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 1754893006: Fix multibuffer crashing bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK -> CHECK Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/multibuffer.cc ('k') | media/blink/multibuffer_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_data_source_unittest.cc
diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc
index ba90f1c62fbdef18c2b33f4a9c12f6b2fb63ccc4..a855001f97d03dceab3dde27caa13f1feef4da0b 100644
--- a/media/blink/multibuffer_data_source_unittest.cc
+++ b/media/blink/multibuffer_data_source_unittest.cc
@@ -1249,4 +1249,33 @@ TEST_F(MultibufferDataSourceTest, SeekPastEOF) {
Stop();
}
+TEST_F(MultibufferDataSourceTest, Http_RetryThenRedirect) {
+ InitializeWith206Response();
+
+ // Read to advance our position.
+ EXPECT_CALL(*this, ReadCallback(kDataSize));
+ ReadAt(0);
+
+ // Issue a pending read but trigger an error to force a retry.
+ EXPECT_CALL(*this, ReadCallback(kDataSize - 10));
+ EXPECT_CALL(host_, AddBufferedByteRange(0, kDataSize * 2));
+ ReadAt(kDataSize + 10, kDataSize - 10);
+ base::RunLoop run_loop;
+ data_provider()->didFail(url_loader(), response_generator_->GenerateError());
+ data_provider()->RunOnStart(run_loop.QuitClosure());
+ run_loop.Run();
+
+ // Server responds with a redirect.
+ blink::WebURLRequest request((GURL(kHttpDifferentPathUrl)));
+ blink::WebURLResponse response((GURL(kHttpUrl)));
+ response.setHTTPStatusCode(307);
+ data_provider()->willFollowRedirect(url_loader(), request, response);
+ Respond(response_generator_->Generate206(kDataSize));
+ ReceiveData(kDataSize);
+ EXPECT_CALL(host_, AddBufferedByteRange(0, kDataSize * 3));
+ FinishLoading();
+ EXPECT_FALSE(loading());
+ Stop();
+}
+
} // namespace media
« no previous file with comments | « media/blink/multibuffer.cc ('k') | media/blink/multibuffer_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698