NTP4: erase bubble promo UI

chrome/browser/resources/ntp4/new_tab.js

Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 85efee7c4f7dcbd923185f3bf82e21880381d720..bb020a7614802f31c774019e41069244b68fc16f 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -20,14 +20,6 @@ cr.define('ntp', function() {
   var newTabView;
 
   /**
-   * If non-null, an info bubble for showing messages to the user. It points at
-   * the Most Visited label, and is used to draw more attention to the
-   * navigation dot UI.
-   * @type {!cr.ui.Bubble|undefined}
-   */
-  var promoBubble;
-
-  /**
    * If non-null, an bubble confirming that the user has signed into sync. It
    * points at the login status at the top of the page.
    * @type {!cr.ui.Bubble|undefined}
@@ -88,17 +80,7 @@ cr.define('ntp', function() {
                     pageSwitcherStart, pageSwitcherEnd);
   }
 
-  NewTabView.prototype = {
-    __proto__: ntp.PageListView.prototype,
-
-    /** @override */
-    appendTilePage: function(page, title, titleIsEditable, opt_refNode) {
-      ntp.PageListView.prototype.appendTilePage.apply(this, arguments);
-
-      if (promoBubble)
-        window.setTimeout(promoBubble.reposition.bind(promoBubble), 0);
-    }
-  };
+  NewTabView.prototype = {__proto__: ntp.PageListView.prototype};

[Dan Beam, 2016/03/01 21:52:22]

could I fix this silly single inheritance?  yes, but it's not high on my
priority list at the moment

[Evan Stade, 2016/03/01 22:25:34]

at least a TODO would be nice

[Dan Beam, 2016/03/01 22:36:06]

Done.

 
   /**
    * Invoked at startup once the DOM is available to initialize the app.
@@ -160,30 +142,6 @@ cr.define('ntp', function() {
       shouldShowLoginBubble = true;
     }
 
-    if (loadTimeData.valueExists('bubblePromoText')) {
-      promoBubble = new cr.ui.Bubble;
-      promoBubble.anchorNode = getRequiredElement('promo-bubble-anchor');
-      promoBubble.arrowLocation = cr.ui.ArrowLocation.BOTTOM_START;
-      promoBubble.bubbleAlignment = cr.ui.BubbleAlignment.ENTIRELY_VISIBLE;
-      promoBubble.deactivateToDismissDelay = 2000;
-      promoBubble.content = parseHtmlSubset(
-          loadTimeData.getString('bubblePromoText'), ['BR']);
-
-      var bubbleLink = promoBubble.querySelector('a');
-      if (bubbleLink) {
-        bubbleLink.addEventListener('click', function(e) {
-          chrome.send('bubblePromoLinkClicked');
-        });
-      }
-
-      promoBubble.handleCloseEvent = function() {
-        promoBubble.hide();
-        chrome.send('bubblePromoClosed');
-      };
-      promoBubble.show();
-      chrome.send('bubblePromoViewed');
-    }
-
     $('login-container').addEventListener('click', showSyncLoginUI);
     if (loadTimeData.getBoolean('shouldShowSyncLogin'))
       chrome.send('initializeSyncLogin');