NTP4: erase bubble promo UI

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
 // Use an anonymous function to enable strict mode just for this file (which
 // will be concatenated with other files when embedded in Chrome
 cr.define('ntp', function() {
   'use strict';
 
   /**
    * NewTabView instance.
    * @type {!Object|undefined}
    */
   var newTabView;
 
   /**
-   * If non-null, an info bubble for showing messages to the user. It points at
-   * the Most Visited label, and is used to draw more attention to the
-   * navigation dot UI.
-   * @type {!cr.ui.Bubble|undefined}
-   */
-  var promoBubble;
-
-  /**
    * If non-null, an bubble confirming that the user has signed into sync. It
    * points at the login status at the top of the page.
    * @type {!cr.ui.Bubble|undefined}
    */
   var loginBubble;
 
   /**
    * true if |loginBubble| should be shown.
    * @type {boolean}
    */
@@ skipping 40 matching lines @@
       pageSwitcherEnd = /** @type {!ntp.PageSwitcher} */(
           getRequiredElement('page-switcher-end'));
     }
     this.initialize(getRequiredElement('page-list'),
                     getRequiredElement('dot-list'),
                     getRequiredElement('card-slider-frame'),
                     getRequiredElement('trash'),
                     pageSwitcherStart, pageSwitcherEnd);
   }
 
-  NewTabView.prototype = {
-    __proto__: ntp.PageListView.prototype,
-
-    /** @override */
-    appendTilePage: function(page, title, titleIsEditable, opt_refNode) {
-      ntp.PageListView.prototype.appendTilePage.apply(this, arguments);
-
-      if (promoBubble)
-        window.setTimeout(promoBubble.reposition.bind(promoBubble), 0);
-    }
-  };
+  NewTabView.prototype = {__proto__: ntp.PageListView.prototype};

[Dan Beam, 2016/03/01 21:52:22]

could I fix this silly single inheritance?  yes, but it's not high on my
priority list at the moment

[Evan Stade, 2016/03/01 22:25:34]

at least a TODO would be nice

[Dan Beam, 2016/03/01 22:36:06]

Done.

 
   /**
    * Invoked at startup once the DOM is available to initialize the app.
    */
   function onLoad() {
     sectionsToWaitFor = 0;
     if (loadTimeData.getBoolean('showApps')) {
       sectionsToWaitFor++;
       if (loadTimeData.getBoolean('showAppLauncherPromo')) {
         $('app-launcher-promo-close-button').addEventListener('click',
@@ skipping 41 matching lines @@
       $('login-status-dismiss').onclick = loginBubble.hide.bind(loginBubble);
 
       var bubbleContent = $('login-status-bubble-contents');
       loginBubble.content = bubbleContent;
 
       // The anchor node won't be updated until updateLogin is called so don't
       // show the bubble yet.
       shouldShowLoginBubble = true;
     }
 
-    if (loadTimeData.valueExists('bubblePromoText')) {
-      promoBubble = new cr.ui.Bubble;
-      promoBubble.anchorNode = getRequiredElement('promo-bubble-anchor');
-      promoBubble.arrowLocation = cr.ui.ArrowLocation.BOTTOM_START;
-      promoBubble.bubbleAlignment = cr.ui.BubbleAlignment.ENTIRELY_VISIBLE;
-      promoBubble.deactivateToDismissDelay = 2000;
-      promoBubble.content = parseHtmlSubset(
-          loadTimeData.getString('bubblePromoText'), ['BR']);
-
-      var bubbleLink = promoBubble.querySelector('a');
-      if (bubbleLink) {
-        bubbleLink.addEventListener('click', function(e) {
-          chrome.send('bubblePromoLinkClicked');
-        });
-      }
-
-      promoBubble.handleCloseEvent = function() {
-        promoBubble.hide();
-        chrome.send('bubblePromoClosed');
-      };
-      promoBubble.show();
-      chrome.send('bubblePromoViewed');
-    }
-
     $('login-container').addEventListener('click', showSyncLoginUI);
     if (loadTimeData.getBoolean('shouldShowSyncLogin'))
       chrome.send('initializeSyncLogin');
 
     doWhenAllSectionsReady(function() {
       // Tell the slider about the pages.
       newTabView.updateSliderCards();
       // Mark the current page.
       newTabView.cardSlider.currentCardValue.navigationDot.classList.add(
           'selected');
@@ skipping 300 matching lines @@
     setBookmarkBarAttached: setBookmarkBarAttached,
     setFaviconDominantColor: setFaviconDominantColor,
     themeChanged: themeChanged,
     updateLogin: updateLogin
   };
 });
 
 document.addEventListener('DOMContentLoaded', ntp.onLoad);
 
 var toCssPx = cr.ui.toCssPx;