infra/bots/perf_skia.isolate - Issue 1754843002: Swarming bots: Add support for perf steps

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/perf_skia.isolate

Issue 1754843002: Swarming bots: Add support for perf steps (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 'includes': [	2 'includes': [

3 'images.isolate',	3 'images.isolate',

4 'skia_repo.isolate',	4 'skia_repo.isolate',

5 'skps.isolate',	5 'skps.isolate',

6 ],	6 ],

7 'variables': {	7 'variables': {

8 'command': [	8 'command': [

9 'python', 'test_skia.py', '--master_name', '<(MASTER_NAME)', '--builder_na me', '<(BUILDER_NAME)', '--build_number', '<(BUILD_NUMBER)', '--slave_name', '<( SLAVE_NAME)', '--revision', '<(REVISION)', '--swarm_out_dir', '${ISOLATED_OUTDIR }',	9 'python', 'perf_skia.py', '--master_name', '<(MASTER_NAME)', '--builder_na me', '<(BUILDER_NAME)', '--build_number', '<(BUILD_NUMBER)', '--slave_name', '<( SLAVE_NAME)', '--revision', '<(REVISION)', '--swarm_out_dir', '${ISOLATED_OUTDIR }',
	rmistry 2016/03/02 14:37:18 If this is the only difference between the isolate If this is the only difference between the isolate and the script then you should be able to combine them into a single one to remove duplication. But if you expect there to be differences in arguments very soon then you should keep them separate. borenet 2016/03/02 14:42:46 The fact that they're almost the same is really co Show quoted text On 2016/03/02 14:37:18, rmistry wrote: > If this is the only difference between the isolate and the script then you > should be able to combine them into a single one to remove duplication. > But if you expect there to be differences in arguments very soon then you should > keep them separate. The fact that they're almost the same is really coincidental. I'd like them to be separate.
10 ],	10 ],

11 },	11 },

12 }	12 }

OLD	NEW

« no previous file with comments | « infra/bots/common.py ('k') | infra/bots/perf_skia.py » ('j') | no next file with comments »