Swarming bots: Add support for perf steps

Swarming bots: Add support for perf steps

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754843002

Committed: https://skia.googlesource.com/skia/+/c803ef125d98429abbbe2679f4a8c6bc7bf10f85

[borenet, 2016-03-01 21:49:40]

Description was changed from

==========
Swarming bots: Add support for perf steps

BUG=skia:4763
==========

to

==========
Swarming bots: Add support for perf steps

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-01 21:50:07]

Description was changed from

==========
Swarming bots: Add support for perf steps

BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming bots: Add support for perf steps

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[borenet, 2016-03-01 21:50:15]

borenet@google.com changed reviewers:
+ rmistry@google.com

[borenet, 2016-03-02 12:54:37]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 12:54:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754843002/10004
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754843002/10004

[commit-bot: I haz the power, 2016-03-02 12:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 12:55:59]

Dry run: This issue passed the CQ dry run.

[borenet, 2016-03-02 14:29:21]

Friendly ping.

[rmistry, 2016-03-02 14:37:18]

lgtm

https://codereview.chromium.org/1754843002/diff/50001/infra/bots/perf_skia.is...
File infra/bots/perf_skia.isolate (right):

https://codereview.chromium.org/1754843002/diff/50001/infra/bots/perf_skia.is...
infra/bots/perf_skia.isolate:9: 'python', 'perf_skia.py', '--master_name',
'<(MASTER_NAME)', '--builder_name', '<(BUILDER_NAME)', '--build_number',
'<(BUILD_NUMBER)', '--slave_name', '<(SLAVE_NAME)', '--revision', '<(REVISION)',
'--swarm_out_dir', '${ISOLATED_OUTDIR}',
If this is the only difference between the isolate and the script then you
should be able to combine them into a single one to remove duplication.
But if you expect there to be differences in arguments very soon then you should
keep them separate.

[borenet, 2016-03-02 14:42:46]

https://codereview.chromium.org/1754843002/diff/50001/infra/bots/perf_skia.is...
File infra/bots/perf_skia.isolate (right):

https://codereview.chromium.org/1754843002/diff/50001/infra/bots/perf_skia.is...
infra/bots/perf_skia.isolate:9: 'python', 'perf_skia.py', '--master_name',
'<(MASTER_NAME)', '--builder_name', '<(BUILDER_NAME)', '--build_number',
'<(BUILD_NUMBER)', '--slave_name', '<(SLAVE_NAME)', '--revision', '<(REVISION)',
'--swarm_out_dir', '${ISOLATED_OUTDIR}',
On 2016/03/02 14:37:18, rmistry wrote:
> If this is the only difference between the isolate and the script then you
> should be able to combine them into a single one to remove duplication.
> But if you expect there to be differences in arguments very soon then you
should
> keep them separate.

The fact that they're almost the same is really coincidental.  I'd like them to
be separate.

[borenet, 2016-03-02 14:43:15]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-03-02 14:43:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754843002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754843002/50001

[commit-bot: I haz the power, 2016-03-02 16:06:30]

Description was changed from

==========
Swarming bots: Add support for perf steps

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Swarming bots: Add support for perf steps

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/c803ef125d98429abbbe2679f4a8c6bc7bf10f85
==========

[commit-bot: I haz the power, 2016-03-02 16:06:31]

Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/c803ef125d98429abbbe2679f4a8c6bc7bf10f85