Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1754813004: Add thread safe constant canonicalization. (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : c #

Total comments: 1

Patch Set 4 : Move allocation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -101 lines) Patch
M runtime/vm/isolate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 5 chunks +213 lines, -101 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 9 months ago (2016-03-02 18:32:03 UTC) #2
siva
LGTM with one comment. https://codereview.chromium.org/1754813004/diff/40001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1754813004/diff/40001/runtime/vm/object.cc#newcode14484 runtime/vm/object.cc:14484: } As discussed offline this ...
4 years, 9 months ago (2016-03-02 19:12:07 UTC) #3
srdjan
4 years, 9 months ago (2016-03-02 20:12:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4128c31916c8809f1739a4e521eed548ba81ac74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698