test/_data/synthetic/synthetic.dart - Issue 1754813003: Suppress lints on synthetic nodes/tokens (#193).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/_data/synthetic/synthetic.dart

Issue 1754813003: Suppress lints on synthetic nodes/tokens (#193). (Closed) Base URL: https://github.com/dart-lang/linter.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Verifies that synthetic nodes don't get lints.

	2 // `XXX` below is synthetic
	Brian Wilkerson 2016/03/01 21:26:54 That can't be true because synthetic tokens are al That can't be true because synthetic tokens are always zero length. I think what's happening is that we're inserting a synthetic token after 'XXX' and that's what's causing the lint to fire. pquitslund 2016/03/01 21:30:01 You're right! I just figured that out myself (see Show quoted text On 2016/03/01 21:26:54, Brian Wilkerson wrote: > That can't be true because synthetic tokens are always zero length. I think > what's happening is that we're inserting a synthetic token after 'XXX' and > that's what's causing the lint to fire. You're right! I just figured that out myself (see screenshot here: https://github.com/dart-lang/sdk/issues/25876). Will fix.
	3 // See: https://github.com/dart-lang/linter/issues/193

	4 void main() { }

	5 XXX

OLD	NEW