Implement Stub for policy bridge to ARC

chrome/browser/chromeos/arc/arc_policy_bridge.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/arc/arc_policy_bridge.h"
+
+#include "base/logging.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
+#include "chrome/browser/policy/profile_policy_connector.h"
+#include "chrome/browser/policy/profile_policy_connector_factory.h"
+#include "components/policy/core/common/policy_map.h"
+#include "components/policy/core/common/policy_namespace.h"
+#include "components/user_manager/user.h"
+#include "mojo/public/cpp/bindings/string.h"
+
+namespace arc {
+
+ArcPolicyBridge::ArcPolicyBridge(ArcBridgeService* bridge_service)
+    : ArcService(bridge_service), binding_(this) {
+  VLOG(1) << "ArcPolicyBridge::ArcPolicyBridge";
+  arc_bridge_service()->AddObserver(this);
+}
+
+ArcPolicyBridge::~ArcPolicyBridge() {
+  VLOG(1) << "ArcPolicyBridge::~ArcPolicyBridge";
+  arc_bridge_service()->RemoveObserver(this);
+}
+
+void ArcPolicyBridge::OnPolicyInstanceReady() {
+  VLOG(1) << "ArcPolicyBridge::OnPolicyInstanceReady";
+  const user_manager::UserList& user_list =
+      user_manager::UserManager::Get()->GetLoggedInUsers();
+  DCHECK(user_list.size() == 1);

[Luis Héctor Chávez, 2016/03/15 18:01:56]

Is it possible to change this for
user_manager::UserManager::Get()->GetActiveUser()/GetPrimaryUser();? This DCHECK
looks worrisome.

If you can't change it, please add a comment explaining why adding this DCHECK
is the right choice and how it will be guaranteed that it will never trigger
spuriously.

[phweiss, 2016/03/16 18:45:12]

I changed this to using the active user.

[Thiemo Nagel, 2016/03/16 19:59:33]

Primary user would make more sense to me but in practice it should not make a
difference.

[phweiss, 2016/03/17 15:52:59]

I dont have a preference, changed it to primary.

+  Profile* const profile =
+      chromeos::ProfileHelper::Get()->GetProfileByUser(user_list.front());
+  policy_service_ =
+      policy::ProfilePolicyConnectorFactory::GetForBrowserContext(profile)
+          ->policy_service();
+  policy_service_->AddObserver(policy::POLICY_DOMAIN_CHROME, this);
+
+  PolicyInstance* const policy_instance =
+      arc_bridge_service()->policy_instance();
+  if (!policy_instance) {
+    LOG(ERROR) << "OnPolicyInstanceReady called, but no policy instance found";
+    return;
+  }
+
+  policy_instance->Init(binding_.CreateInterfacePtrAndBind());
+}
+
+void ArcPolicyBridge::OnPolicyInstanceClosed() {
+  VLOG(1) << "ArcPolicyBridge::OnPolicyInstanceClosed";
+  policy_service_->RemoveObserver(policy::POLICY_DOMAIN_CHROME, this);
+  policy_service_ = nullptr;
+}
+
+void ArcPolicyBridge::GetPolicy(const GetPolicyCallback& callback) {
+  VLOG(1) << "ArcPolicyBridge::GetPolicy";
+  // TODO(phweiss): Get actual policies

[Luis Héctor Chávez, 2016/03/15 18:01:56]

Regardless of the decision mentioned in policy.mojom, please be consistent with
the number. Either only use "policy" or "policies".

[phweiss, 2016/03/17 15:52:59]

Renamed the function to GetPolicies, also for consistency with the PolicyService
class.

+  const std::string stub_policy =
+      "{\"applications\":[{\"packageName\":"
+      "\"com.android.chrome\",\"installType\":\"REQUIRED\",\"lockTaskAllowed\":"
+      "false,\"permissionGrants\":[]}]}";
+  callback.Run(mojo::String(stub_policy));
+}
+
+void ArcPolicyBridge::OnPolicyUpdated(const policy::PolicyNamespace& ns,
+                                      const policy::PolicyMap& previous,
+                                      const policy::PolicyMap& current) {
+  VLOG(1) << "ArcPolicyBridge::OnPolicyUpdated";
+  arc_bridge_service()->policy_instance()->OnPolicyChanged();

[Luis Héctor Chávez, 2016/03/15 18:01:56]

It's probably a good idea to add DCHECKs that
arc_bridge_service()->policy_instance() is not null in all places you access it.

[phweiss, 2016/03/16 18:45:12]

Done.

+}
+
+}  // namespace arc