components/autofill/core/browser/credit_card_field.cc - Issue 1754793003: [Autofill] Fix heuristics to detect cc-number on united.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card_field.cc

Issue 1754793003: [Autofill] Fix heuristics to detect cc-number on united.com. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/credit_card_field.cc

diff --git a/components/autofill/core/browser/credit_card_field.cc b/components/autofill/core/browser/credit_card_field.cc

index 89d356351bd6493671cf5d69ea54cf7306f3c0ec..b53bf56f55446ee59b4d6a780f6e83036b873c6f 100644

--- a/components/autofill/core/browser/credit_card_field.cc

+++ b/components/autofill/core/browser/credit_card_field.cc

@@ -137,9 +137,8 @@ scoped_ptr<FormField> CreditCardField::Parse(AutofillScanner* scanner) {

}

AutofillField* current_number_field;

- if (ParseFieldSpecifics(scanner,

- base::UTF8ToUTF16(kCardNumberRe),

- kMatchNumAndTel,

+ if (ParseFieldSpecifics(scanner, base::UTF8ToUTF16(kCardNumberRe),

Mathieu 2016/03/02 19:24:04 Let's put a TODO with a crbug to revisit this in t

sebsg 2016/03/03 22:34:01 Done.

+ kMatchNumAndTel | MATCH_PASSWORD,

&current_number_field)) {

// Avoid autofilling any credit card number field having very low or high

// |start_index| on the HTML form.

« no previous file with comments | « chrome/test/data/autofill/heuristics/output/138_cc_checkout_united.com.out ('k') | no next file » | no next file with comments »