Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1754793002: Add major and minor version numbers to summary files. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add major and minor version numbers to summary files. Note: my expectation is that we won't start bumping the version numbers until summaries begin being used in the wild. While summary support remains experimental, the version number will remain at 1.0. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/92176ad4820c36bddd97ae0b05a740b0d9deeb34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -2 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +55 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-01 19:39:52 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-01 20:14:28 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-01 20:21:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92176ad4820c36bddd97ae0b05a740b0d9deeb34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698