Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1754783002: Fix #469 (Closed)

Created:
4 years, 9 months ago by vsm
Modified:
4 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix #469 The real issue here is static type errors in dart:html code, which we need to cleanup. But it doesn't appear to ever make sense to use the static type here. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/453848673dc5f6c28f79ff225dcca33c2b09611a

Patch Set 1 #

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M lib/runtime/dart/html.js View 6 chunks +9 lines, -9 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 9 months ago (2016-03-01 19:04:39 UTC) #3
Jennifer Messerly
lgtm, definitely no point in passing the type since we're already in an "if (dynamic ...
4 years, 9 months ago (2016-03-01 19:28:16 UTC) #4
vsm
4 years, 9 months ago (2016-03-01 21:01:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
453848673dc5f6c28f79ff225dcca33c2b09611a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698