Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tool/input_sdk/private/operations.dart

Issue 1754773002: Fix internal NSM helper to use a Dart Symbol (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Canonical symbol Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_runtime.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/operations.dart
diff --git a/tool/input_sdk/private/operations.dart b/tool/input_sdk/private/operations.dart
index dcac6ff47eb4f0dfd201a17b0b965e3332a74f37..56308aebf2b35f354f20db5d56f4b2fcdab4438a 100644
--- a/tool/input_sdk/private/operations.dart
+++ b/tool/input_sdk/private/operations.dart
@@ -74,9 +74,12 @@ checkApply(type, actuals) => JS('', '''(() => {
return true;
})()''');
+_dartSymbol(name) => JS('', '''
+ $const_($Symbol.new($name.toString()))
+''');
throwNoSuchMethod(obj, name, pArgs, nArgs, extras) => JS('', '''(() => {
- $throw_(new $NoSuchMethodError($obj, $name, $pArgs, $nArgs, $extras));
+ $throw_(new $NoSuchMethodError($obj, $_dartSymbol($name), $pArgs, $nArgs, $extras));
})()''');
throwNoSuchMethodFunc(obj, name, pArgs, opt_func) => JS('', '''(() => {
« no previous file with comments | « lib/runtime/dart/_runtime.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698