Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: lib/runtime/dart/_runtime.js

Issue 1754773002: Fix internal NSM helper to use a Dart Symbol (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Canonical symbol Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tool/input_sdk/private/operations.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 dart_library.library('dart/_runtime', null, /* Imports */[ 1 dart_library.library('dart/_runtime', null, /* Imports */[
2 ], /* Lazy imports */[ 2 ], /* Lazy imports */[
3 'dart/core', 3 'dart/core',
4 'dart/_interceptors', 4 'dart/_interceptors',
5 'dart/_js_helper', 5 'dart/_js_helper',
6 'dart/async', 6 'dart/async',
7 'dart/collection' 7 'dart/collection'
8 ], function(exports, core, _interceptors, _js_helper, async, collection) { 8 ], function(exports, core, _interceptors, _js_helper, async, collection) {
9 'use strict'; 9 'use strict';
10 function mixin(base, ...mixins) { 10 function mixin(base, ...mixins) {
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 let names = getOwnPropertyNames(opts); 419 let names = getOwnPropertyNames(opts);
420 if (names.length == 0) return false; 420 if (names.length == 0) return false;
421 for (var name of names) { 421 for (var name of names) {
422 if (!hasOwnProperty.call(type.named, name)) { 422 if (!hasOwnProperty.call(type.named, name)) {
423 return false; 423 return false;
424 } 424 }
425 if (!instanceOfOrNull(opts[name], type.named[name])) return false; 425 if (!instanceOfOrNull(opts[name], type.named[name])) return false;
426 } 426 }
427 return true; 427 return true;
428 } 428 }
429 function _dartSymbol(name) {
430 return const_(core.Symbol.new(name.toString()));
431 }
429 function throwNoSuchMethod(obj, name, pArgs, nArgs, extras) { 432 function throwNoSuchMethod(obj, name, pArgs, nArgs, extras) {
430 throw_(new core.NoSuchMethodError(obj, name, pArgs, nArgs, extras)); 433 throw_(new core.NoSuchMethodError(obj, _dartSymbol(name), pArgs, nArgs, extr as));
431 } 434 }
432 function throwNoSuchMethodFunc(obj, name, pArgs, opt_func) { 435 function throwNoSuchMethodFunc(obj, name, pArgs, opt_func) {
433 if (obj === void 0) obj = opt_func; 436 if (obj === void 0) obj = opt_func;
434 throwNoSuchMethod(obj, name, pArgs); 437 throwNoSuchMethod(obj, name, pArgs);
435 } 438 }
436 function checkAndCall(f, ftype, obj, args, name) { 439 function checkAndCall(f, ftype, obj, args, name) {
437 let originalFunction = f; 440 let originalFunction = f;
438 if (!(f instanceof Function)) { 441 if (!(f instanceof Function)) {
439 if (f != null) { 442 if (f != null) {
440 ftype = getMethodType(f, 'call'); 443 ftype = getMethodType(f, 'call');
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
1317 exports.copyProperties = copyProperties; 1320 exports.copyProperties = copyProperties;
1318 exports.export = export_; 1321 exports.export = export_;
1319 exports.defineLazyClass = defineLazyClass; 1322 exports.defineLazyClass = defineLazyClass;
1320 exports.defineLazyProperties = defineLazyProperties; 1323 exports.defineLazyProperties = defineLazyProperties;
1321 exports.defineLazyClassGeneric = defineLazyClassGeneric; 1324 exports.defineLazyClassGeneric = defineLazyClassGeneric;
1322 exports.as = as_; 1325 exports.as = as_;
1323 exports.is = is_; 1326 exports.is = is_;
1324 exports.global = global_; 1327 exports.global = global_;
1325 exports.JsSymbol = JsSymbol; 1328 exports.JsSymbol = JsSymbol;
1326 }); 1329 });
OLDNEW
« no previous file with comments | « no previous file | tool/input_sdk/private/operations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698