Fix internal NSM helper to use a Dart Symbol

Fix internal NSM helper to use a Dart Symbol

Not sure if this entirely handles #470, but it does fix the breaking example.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/63045d8cf4533333e9be8ca910246aaf93903b5b

[vsm, 2016-03-01 18:32:26]

Description was changed from

==========
Fix internal NSM helper to use a Dart Symbol

Not sure if this entirely handles #470, but it does fix the breaking example.
==========

to

==========
Fix internal NSM helper to use a Dart Symbol

Not sure if this entirely handles #470, but it does fix the breaking example.
==========

[vsm, 2016-03-01 18:32:26]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-03-01 19:26:17]

Well it's definitely an improvement, so LGTM in that sense. :)

Not sure this correctly converts Dart Symbols... they need to have certain
equality properties, right? e.g. each time I hit nSM, I should get the same
memberName.

Probably doesn't affect the "throw" path, but if we're calling user-defined nSM,
we should pass the same (identical) instance each time, presumably? In other
words Dart symbols should be canonicalized (similar to const). Maybe that
happens in the Symbol.new factory?

[vsm, 2016-03-01 21:23:29]

On 2016/03/01 19:26:17, John Messerly wrote:
> Well it's definitely an improvement, so LGTM in that sense. :)
> 
> Not sure this correctly converts Dart Symbols... they need to have certain
> equality properties, right? e.g. each time I hit nSM, I should get the same
> memberName.

> Probably doesn't affect the "throw" path, but if we're calling user-defined
nSM,
> we should pass the same (identical) instance each time, presumably? In other
> words Dart symbols should be canonicalized (similar to const). Maybe that
> happens in the Symbol.new factory?

Added const to the construction.  In this case, there is no way to tell though -
since we don't support noSuchMethod yet.  :-)

[vsm, 2016-03-11 17:06:15]

Description was changed from

==========
Fix internal NSM helper to use a Dart Symbol

Not sure if this entirely handles #470, but it does fix the breaking example.
==========

to

==========
Fix internal NSM helper to use a Dart Symbol

Not sure if this entirely handles #470, but it does fix the breaking example.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/63045d8cf4533333e9be8ca91024...
==========

[vsm, 2016-03-11 17:06:16]

Committed patchset #2 (id:20001) manually as
63045d8cf4533333e9be8ca910246aaf93903b5b (presubmit successful).