Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1754703008: Clear fields sticky_error and pending_functions when unscheduling thread; enable background compila… (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clear fields sticky_error and pending_functions when unscheduling thread; enable background compilation BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1cc5dab2f2a428f3b55cf71734b0504a5e6a847d

Patch Set 1 #

Patch Set 2 : t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/flag_list.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 9 months ago (2016-03-03 19:17:15 UTC) #2
rmacnak
lgtm
4 years, 9 months ago (2016-03-03 19:18:53 UTC) #3
srdjan
Thanks (removed clearing of sticky error, as it is done independently)
4 years, 9 months ago (2016-03-03 20:22:39 UTC) #4
srdjan
4 years, 9 months ago (2016-03-03 20:32:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1cc5dab2f2a428f3b55cf71734b0504a5e6a847d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698