Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1754703007: [Downloads] Simplify DownloadContentTests. (Closed)

Created:
4 years, 9 months ago by asanka
Modified:
4 years, 9 months ago
Reviewers:
svaldez
CC:
asanka, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Simplify DownloadContentTests. There used to be two download resumption code paths. DownloadItemImpl chose the applicable code path based on whether the WebContents that initiated the download was still around. Now DownloadItemImpl deterministically uses the no-WebContents code path. Hence the parameterized tests that exercised both paths no longer need to do so. BUG=7648 Committed: https://crrev.com/4faa7714d832789e56fc2064ac86e3af61557bee Cr-Commit-Position: refs/heads/master@{#379026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -154 lines) Patch
M content/browser/download/download_browsertest.cc View 37 chunks +71 lines, -154 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
asanka
4 years, 9 months ago (2016-03-03 16:44:57 UTC) #2
svaldez
lgtm.
4 years, 9 months ago (2016-03-03 16:54:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754703007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754703007/1
4 years, 9 months ago (2016-03-03 16:55:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 17:18:44 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:20:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4faa7714d832789e56fc2064ac86e3af61557bee
Cr-Commit-Position: refs/heads/master@{#379026}

Powered by Google App Engine
This is Rietveld 408576698