Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1754633002: SkDebugCanvas ignore batch bounds if they are offscreen (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M include/private/GrAuditTrail.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrAuditTrail.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 3 chunks +11 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
joshualitt
please take a look. this CL just hangs the rendertarget ID on some of GrAuditTrail's ...
4 years, 9 months ago (2016-03-01 13:26:53 UTC) #3
bsalomon
https://codereview.chromium.org/1754633002/diff/1/tools/debugger/SkDebugCanvas.cpp File tools/debugger/SkDebugCanvas.cpp (right): https://codereview.chromium.org/1754633002/diff/1/tools/debugger/SkDebugCanvas.cpp#newcode335 tools/debugger/SkDebugCanvas.cpp:335: SkBaseDevice* bd = canvas->getDevice_just_for_deprecated_compatibility_testing(); Don't love it but it's ...
4 years, 9 months ago (2016-03-01 14:50:12 UTC) #4
ethannicholas
lgtm
4 years, 9 months ago (2016-03-01 14:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754633002/1
4 years, 9 months ago (2016-03-01 15:04:21 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 15:15:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d7decffbc34a438fe5eacda17211a10ba72eac2

Powered by Google App Engine
This is Rietveld 408576698