Added policy for disabling locally managed users.

chrome/browser/chromeos/login/user_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstdlib>
 #include <cstring>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/prefs/pref_service.h"
@@ skipping 29 matching lines @@
 
     // Replace the real DeviceSettingsProvider with a stub.
     device_settings_provider_ =
         cros_settings_->GetProvider(chromeos::kReportDeviceVersionInfo);
     EXPECT_TRUE(device_settings_provider_);
     EXPECT_TRUE(
         cros_settings_->RemoveSettingsProvider(device_settings_provider_));
     cros_settings_->AddSettingsProvider(&stub_settings_provider_);
 
     // Populate the stub DeviceSettingsProvider with valid values.
-    SetDeviceSettings(false, "");
+    SetDeviceSettings(false, "", false);
 
     // Register an in-memory local settings instance.
     local_state_.reset(new TestingPrefServiceSimple);
     reinterpret_cast<TestingBrowserProcess*>(g_browser_process)
         ->SetLocalState(local_state_.get());
     UserManager::RegisterPrefs(local_state_->registry());
     // Wallpaper manager and user image managers prefs will be accessed by the
     // unit-test as well.
     UserImageManager::RegisterPrefs(local_state_->registry());
     WallpaperManager::RegisterPrefs(local_state_->registry());
@@ skipping 15 matching lines @@
     DeviceSettingsService::Get()->UnsetSessionManager();
 
     base::RunLoop().RunUntilIdle();
   }
 
   bool GetUserManagerEphemeralUsersEnabled() const {
     return reinterpret_cast<UserManagerImpl*>(UserManager::Get())->
         ephemeral_users_enabled_;
   }
 
+  bool GetUserManagerLocallyManagedUsersEnabledByPolicy() const {
+    return reinterpret_cast<UserManagerImpl*>(UserManager::Get())->

[Bernhard Bauer, 2013/06/21 11:59:25]

I know this is copy-and-pasted from other code here, but is there a reason
you're using a reinterpret_cast instead of a static_cast? Static cast is usually
preferred.

[dzhioev (left Google), 2013/06/21 13:42:29]

Yes, reinterpret_cast is unnecessary here. Removed all occurrences. 

+        locally_managed_users_enabled_by_policy_;
+  }
+
   void SetUserManagerEphemeralUsersEnabled(bool ephemeral_users_enabled) {
     reinterpret_cast<UserManagerImpl*>(UserManager::Get())->
         ephemeral_users_enabled_ = ephemeral_users_enabled;
   }
 
   const std::string& GetUserManagerOwnerEmail() const {
     return reinterpret_cast<UserManagerImpl*>(UserManager::Get())->
         owner_email_;
   }
 
   void SetUserManagerOwnerEmail(const std::string& owner_email) {
     reinterpret_cast<UserManagerImpl*>(UserManager::Get())->
         owner_email_ = owner_email;
   }
 
   void ResetUserManager() {
     // Reset the UserManager singleton.
     user_manager_enabler_.reset();
     // Initialize the UserManager singleton to a fresh UserManagerImpl instance.
     user_manager_enabler_.reset(
         new ScopedUserManagerEnabler(new UserManagerImpl));
   }
 
   void SetDeviceSettings(bool ephemeral_users_enabled,
-                         const std::string &owner) {
+                         const std::string &owner,
+                         bool locally_managed_users_enabled) {
     base::FundamentalValue
         ephemeral_users_enabled_value(ephemeral_users_enabled);
     stub_settings_provider_.Set(kAccountsPrefEphemeralUsersEnabled,
         ephemeral_users_enabled_value);
     base::StringValue owner_value(owner);
     stub_settings_provider_.Set(kDeviceOwner, owner_value);
+    stub_settings_provider_.Set(kAccountsPrefLocallyManagedUsersEnabled,
+        base::FundamentalValue(locally_managed_users_enabled));
   }
 
   void RetrieveTrustedDevicePolicies() {
     reinterpret_cast<UserManagerImpl*>(UserManager::Get())->
         RetrieveTrustedDevicePolicies();
   }
 
  protected:
   base::MessageLoop message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
 
   CrosSettings* cros_settings_;
   CrosSettingsProvider* device_settings_provider_;
   StubCrosSettingsProvider stub_settings_provider_;
   scoped_ptr<TestingPrefServiceSimple> local_state_;
 
   ScopedTestDeviceSettingsService test_device_settings_service_;
   ScopedStubCrosEnabler stub_cros_enabler_;
   ScopedTestCrosSettings test_cros_settings_;
 
   scoped_ptr<ScopedUserManagerEnabler> user_manager_enabler_;
 };
 
 TEST_F(UserManagerTest, RetrieveTrustedDevicePolicies) {
   SetUserManagerEphemeralUsersEnabled(true);
   SetUserManagerOwnerEmail("");
 
-  SetDeviceSettings(false, "owner@invalid.domain");
+  SetDeviceSettings(false, "owner@invalid.domain", false);
   RetrieveTrustedDevicePolicies();
 
   EXPECT_FALSE(GetUserManagerEphemeralUsersEnabled());
   EXPECT_EQ(GetUserManagerOwnerEmail(), "owner@invalid.domain");
 }
 
 TEST_F(UserManagerTest, RemoveAllExceptOwnerFromList) {
   UserManager::Get()->UserLoggedIn(
       "owner@invalid.domain", "owner@invalid.domain", false);
   ResetUserManager();
   UserManager::Get()->UserLoggedIn(
       "user0@invalid.domain", "owner@invalid.domain", false);
   ResetUserManager();
   UserManager::Get()->UserLoggedIn(
       "user1@invalid.domain", "owner@invalid.domain", false);
   ResetUserManager();
 
   const UserList* users = &UserManager::Get()->GetUsers();
   ASSERT_EQ(3U, users->size());
   EXPECT_EQ((*users)[0]->email(), "user1@invalid.domain");
   EXPECT_EQ((*users)[1]->email(), "user0@invalid.domain");
   EXPECT_EQ((*users)[2]->email(), "owner@invalid.domain");
 
-  SetDeviceSettings(true, "owner@invalid.domain");
+  SetDeviceSettings(true, "owner@invalid.domain", false);
   RetrieveTrustedDevicePolicies();
 
   users = &UserManager::Get()->GetUsers();
   EXPECT_EQ(1U, users->size());
   EXPECT_EQ((*users)[0]->email(), "owner@invalid.domain");
 }
 
 TEST_F(UserManagerTest, RegularUserLoggedInAsEphemeral) {
-  SetDeviceSettings(true, "owner@invalid.domain");
+  SetDeviceSettings(true, "owner@invalid.domain", false);
   RetrieveTrustedDevicePolicies();
 
   UserManager::Get()->UserLoggedIn(
       "owner@invalid.domain", "user0@invalid.domain", false);
   ResetUserManager();
   UserManager::Get()->UserLoggedIn(
       "user0@invalid.domain", "user0@invalid.domain", false);
   ResetUserManager();
 
   const UserList* users = &UserManager::Get()->GetUsers();
   EXPECT_EQ(1U, users->size());
   EXPECT_EQ((*users)[0]->email(), "owner@invalid.domain");
 }
 
+TEST_F(UserManagerTest, DisablingLMUByDeviceSettings) {
+  SetDeviceSettings(false, "owner@invalid.domain", false);
+  RetrieveTrustedDevicePolicies();
+  EXPECT_EQ(GetUserManagerLocallyManagedUsersEnabledByPolicy(), false);
+  SetDeviceSettings(false, "owner@invalid.domain", true);
+  RetrieveTrustedDevicePolicies();
+  EXPECT_EQ(GetUserManagerLocallyManagedUsersEnabledByPolicy(), true);
+
+}
+
 }  // namespace chromeos