Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1754593007: X87: [proxies] throw TypeError if is_callable Map bit is unset. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [proxies] throw TypeError if is_callable Map bit is unset. port 18b9c1ce705e5fe38c23bdd19fcbbfbe3121c611 (r34461) original commit message: Per ProxyCreate() (https://tc39.github.io/ecma262/#sec-proxycreate), a Proxy is only given a [[Call]] slot if the target has a [[Call]] slot as well. This was previously implemented correctly for [[Construct]], but not for [[Call]]. BUG= Committed: https://crrev.com/1736ad786ff96212fe452acb793b9543ca154da6 Cr-Commit-Position: refs/heads/master@{#34478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-04 01:57:11 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-04 05:58:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754593007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754593007/1
4 years, 9 months ago (2016-03-04 07:03:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 07:23:51 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:25:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1736ad786ff96212fe452acb793b9543ca154da6
Cr-Commit-Position: refs/heads/master@{#34478}

Powered by Google App Engine
This is Rietveld 408576698