Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/devtools/protocol.json

Issue 1754483002: [DevTools] Added setBlackboxPatterns method to protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@provide-hash-for-anonymous-scripts
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/protocol.json
diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json
index b8aae7ce399ef8a7d945b5373bc8656447612e62..2e8f124d9a3fb6319a98376865ebc6965c13f7ee 100644
--- a/third_party/WebKit/Source/devtools/protocol.json
+++ b/third_party/WebKit/Source/devtools/protocol.json
@@ -3391,6 +3391,23 @@
"description": "Location in the source code."
},
{
+ "id": "BlackboxPatternType",
pfeldman 2016/03/03 01:20:52 drop this.
kozy 2016/03/03 20:14:18 Done.
+ "hidden": true,
+ "type": "string",
+ "enum": [ "RegExp", "Hash" ],
+ "description": "Blackbox pattern type. RegExp is used for scripts url."
+ },
+ {
+ "id": "BlackboxPattern",
+ "hidden": true,
+ "type": "object",
+ "properties": [
+ { "name": "type", "$ref": "BlackboxPatternType" },
pfeldman 2016/03/03 01:20:52 You should instead have two optional properties he
kozy 2016/03/03 20:14:18 Done.
+ { "name": "value", "type": "string" }
+ ],
+ "description": "Blackbox pattern."
+ },
+ {
"id": "FunctionDetails",
"hidden": true,
"type": "object",
@@ -3799,13 +3816,21 @@
"description": "Removes AsyncOperation breakpoint."
},
{
- "name": "setBlackboxedRanges",
+ "name": "setBlackboxRanges",
"parameters": [
- { "name": "scriptId", "$ref": "Runtime.ScriptId", "description": "Id of the script." },
+ { "name": "hash", "type": "string", "description": "Hash of the script." },
pfeldman 2016/03/03 01:20:52 Introduce type for the hash?
kozy 2016/03/03 20:14:18 Done.
{ "name": "positions", "type": "array", "items": { "$ref": "ScriptPosition" } }
],
"hidden": true,
"description": "Makes backend skip steps in the script in blackboxed ranges. VM will try leave blacklisted scripts by performing 'step in' several times, finally resorting to 'step out' if unsuccessful. Positions array contains positions where blackbox state is changed. First interval isn't blackboxed. Array should be sorted."
+ },
+ {
+ "name": "setBlackboxPatterns",
+ "parameters": [
+ { "name": "patterns", "type": "array", "items": { "$ref": "BlackboxPattern"} }
pfeldman 2016/03/03 01:25:39 After looking at the code, it seems more like you
kozy 2016/03/03 20:14:18 Done.
+ ],
+ "hidden": true,
+ "description": "Makes backend skip steps in the script in blackboxed ranges. VM will try leave blacklisted scripts by performing 'step in' several times, finally resorting to 'step out' if unsuccessful. Pattern can be one of the type: RegExp for url, url, script's hash."
pfeldman 2016/03/03 01:20:52 Comment is wrong.
kozy 2016/03/03 20:14:18 Done.
}
],
"events": [

Powered by Google App Engine
This is Rietveld 408576698