Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/WebKit/Source/devtools/protocol.json

Issue 1754483002: [DevTools] Added setBlackboxPatterns method to protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@provide-hash-for-anonymous-scripts
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/protocol.json
diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json
index 15786518cac3b1cc8c201522282e505d5daa5072..edb4f9c8b3e44656103c06a1cb32de997e95adee 100644
--- a/third_party/WebKit/Source/devtools/protocol.json
+++ b/third_party/WebKit/Source/devtools/protocol.json
@@ -3364,6 +3364,11 @@
"description": "Call frame identifier."
},
{
+ "id": "ScriptHash",
+ "type": "string",
+ "description": "Script's content hash."
+ },
+ {
"id": "Location",
"type": "object",
"properties": [
@@ -3384,6 +3389,18 @@
"description": "Location in the source code."
},
{
+ "id": "BlackboxPattern",
+ "hidden": true,
+ "type": "object",
+ "properties": [
+ { "name": "url", "type": "string", "optional": true },
+ { "name": "hash", "$ref": "ScriptHash", "optional": true },
+ { "name": "regexp", "type": "string", "optional": true },
+ { "name": "positions", "type": "array", "items": { "$ref": "ScriptPosition" }, "optional": true }
+ ],
+ "description": "Pattern contains one of script selector: url, hash or regexp for url and optional positions array if url or hast is set."
+ },
+ {
"id": "FunctionDetails",
"hidden": true,
"type": "object",
@@ -3783,13 +3800,17 @@
"description": "Removes AsyncOperation breakpoint."
},
{
- "name": "setBlackboxedRanges",
+ "name": "addBlackboxPatterns",
"parameters": [
- { "name": "scriptId", "$ref": "Runtime.ScriptId", "description": "Id of the script." },
- { "name": "positions", "type": "array", "items": { "$ref": "ScriptPosition" } }
+ { "name": "patterns", "type": "array", "items": { "$ref": "BlackboxPattern"} }
pfeldman 2016/03/07 19:22:47 Why is the add/clear contract? It is typically eit
kozy 2016/03/08 02:33:20 I'd like to set initial pattern on debugger enable
],
"hidden": true,
"description": "Makes backend skip steps in the script in blackboxed ranges. VM will try leave blacklisted scripts by performing 'step in' several times, finally resorting to 'step out' if unsuccessful. Positions array contains positions where blackbox state is changed. First interval isn't blackboxed. Array should be sorted."
dgozman 2016/03/07 17:26:13 Please move detailed description of positions to B
kozy 2016/03/08 02:33:20 Done.
+ },
+ {
+ "name": "clearBlackboxPatterns",
+ "hidden": true,
+ "description": "Clear all added blackbox patterns."
}
],
"events": [
@@ -3807,7 +3828,7 @@
{ "name": "endLine", "type": "integer", "description": "Last line of the script." },
{ "name": "endColumn", "type": "integer", "description": "Length of the last line of the script." },
{ "name": "executionContextId", "$ref": "Runtime.ExecutionContextId", "description": "Specifies script creation context.", "hidden": true },
- { "name": "hash", "type": "string", "hidden": true, "description": "Content hash of the script."},
+ { "name": "hash", "$ref": "ScriptHash", "optional": true, "hidden": true, "description": "Content hash of the script."},
{ "name": "isContentScript", "type": "boolean", "optional": true, "description": "Determines whether this script is a user extension script." },
{ "name": "isInternalScript", "type": "boolean", "optional": true, "description": "Determines whether this script is an internal script.", "hidden": true },
{ "name": "isLiveEdit", "type": "boolean", "optional": true, "description": "True, if this script is generated as a result of the live edit operation.", "hidden": true },
@@ -3827,7 +3848,7 @@
{ "name": "endLine", "type": "integer", "description": "Last line of the script." },
{ "name": "endColumn", "type": "integer", "description": "Length of the last line of the script." },
{ "name": "executionContextId", "$ref": "Runtime.ExecutionContextId", "description": "Specifies script creation context.", "hidden": true },
- { "name": "hash", "type": "string", "hidden": true, "description": "Content hash of the script."},
+ { "name": "hash", "$ref": "ScriptHash", "optional": true, "hidden": true, "description": "Content hash of the script."},
{ "name": "isContentScript", "type": "boolean", "optional": true, "description": "Determines whether this script is a user extension script." },
{ "name": "isInternalScript", "type": "boolean", "optional": true, "description": "Determines whether this script is an internal script.", "hidden": true },
{ "name": "sourceMapURL", "type": "string", "optional": true, "description": "URL of source map associated with script (if any)." },

Powered by Google App Engine
This is Rietveld 408576698