[DevTools] Added setBlackboxPatterns method to protocol

[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend. Pattern can be one of two types: regexp for url or script's hash.
DebuggerAgent preserves state of blackbox on reattach.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org

[kozy, 2016-03-01 02:17:47]

Patchset #2 (id:20001) has been deleted

[kozy, 2016-03-01 02:17:55]

Patchset #1 (id:1) has been deleted

[kozy, 2016-03-01 02:18:05]

Description was changed from

==========
[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend.
Pattern can be one of three type: regexp for url, url and script's hash. Each
pattern have optional field with blackbox ranges in the script.
DebuggerAgent preserve state of blackbox on reattach and this information, it
allows blackboxing script on load.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend.
Pattern can be one of three type: regexp for url, url and script's hash. Each
pattern have optional field with blackbox ranges in the script.
DebuggerAgent preserve state of blackbox on reattach.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-03-01 02:18:17]

Description was changed from

==========
[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend.
Pattern can be one of three type: regexp for url, url and script's hash. Each
pattern have optional field with blackbox ranges in the script.
DebuggerAgent preserve state of blackbox on reattach.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend.
Pattern can be one of three type: regexp for url, url and script's hash. Each
pattern have optional field with blackbox ranges in the script.
DebuggerAgent preserves state of blackbox on reattach.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-03-01 02:24:26]

ptal

[kozy, 2016-03-03 01:15:52]

Description was changed from

==========
[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend.
Pattern can be one of three type: regexp for url, url and script's hash. Each
pattern have optional field with blackbox ranges in the script.
DebuggerAgent preserves state of blackbox on reattach.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Added setBlackboxPatterns method to protocol

This method set array of patterns that determines blackbox state on backend.
Pattern can be one of two types: regexp for url or script's hash.
DebuggerAgent preserves state of blackbox on reattach.

BUG=341082
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-03-03 01:16:07]

New version uploaded. Ptal!

[pfeldman, 2016-03-03 01:20:52]

releasing early comments while i continue review.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3394: "id":
"BlackboxPatternType",
drop this.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3405: { "name": "type", "$ref":
"BlackboxPatternType" },
You should instead have two optional properties here named "regex" and "hash".

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3821: { "name": "hash", "type":
"string", "description": "Hash of the script." },
Introduce type for the hash?

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3833: "description": "Makes
backend skip steps in the script in blackboxed ranges. VM will try leave
blacklisted scripts by performing 'step in' several times, finally resorting to
'step out' if unsuccessful. Pattern can be one of the type: RegExp for url, url,
script's hash."
Comment is wrong.

[pfeldman, 2016-03-03 01:25:39]

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:186:
.filter(item => !item.disabled)
Did closure compiler resolve item type?

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:188:
return debuggerModel.setBlackboxPatterns(regexPatterns);
It could not possibly resolve this type, so it is treating it as undefined.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3830: { "name": "patterns",
"type": "array", "items": { "$ref": "BlackboxPattern"} }
After looking at the code, it seems more like you either edit the regex pattern
or add a blackboxed hash. Should we structure protocol accordingly?

[kozy, 2016-03-03 20:14:18]

All done. Please take a look!

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:188:
return debuggerModel.setBlackboxPatterns(regexPatterns);
On 2016/03/03 01:25:39, pfeldman wrote:
> It could not possibly resolve this type, so it is treating it as undefined.

Rewrited without awesome filter and map with array iteration. It still doesn't
check with compiler. We should roll the compiler for better supporting this.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3394: "id":
"BlackboxPatternType",
On 2016/03/03 01:20:52, pfeldman wrote:
> drop this.

Done.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3405: { "name": "type", "$ref":
"BlackboxPatternType" },
On 2016/03/03 01:20:52, pfeldman wrote:
> You should instead have two optional properties here named "regex" and "hash".

Done.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3821: { "name": "hash", "type":
"string", "description": "Hash of the script." },
On 2016/03/03 01:20:52, pfeldman wrote:
> Introduce type for the hash?

Done.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3830: { "name": "patterns",
"type": "array", "items": { "$ref": "BlackboxPattern"} }
On 2016/03/03 01:25:39, pfeldman wrote:
> After looking at the code, it seems more like you either edit the regex
pattern
> or add a blackboxed hash. Should we structure protocol accordingly?

Done.

https://codereview.chromium.org/1754483002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:3833: "description": "Makes
backend skip steps in the script in blackboxed ranges. VM will try leave
blacklisted scripts by performing 'step in' several times, finally resorting to
'step out' if unsuccessful. Pattern can be one of the type: RegExp for url, url,
script's hash."
On 2016/03/03 01:20:52, pfeldman wrote:
> Comment is wrong.

Done.

[pfeldman, 2016-03-04 20:22:40]

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h (right):

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h:84: void
editBlackboxPatterns(ErrorString*,
PassOwnPtr<protocol::Array<protocol::Debugger::BlackboxPattern>> patterns)
override;
setBlackboxPatterns

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/protocol.json:3817: "name":
"editBlackboxPatterns",
To recap: setBlackboxPatterns receives array of either hash or url or regex.
Sames goes for setBreakpoint, setBreakpointById is not being used anymore.

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
(right):

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h:293:
HashSet<String> m_loadedScriptHashes;
Should this be a map?

[kozy, 2016-03-06 01:07:55]

Patchset #5 (id:120001) has been deleted

[kozy, 2016-03-06 01:12:10]

Patchset #5 (id:140001) has been deleted

[kozy, 2016-03-06 01:13:09]

All done. Please take a look.
API methods were replaced with addBlackboxPatterns and clearBlackboxPatterns.

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h (right):

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h:84: void
editBlackboxPatterns(ErrorString*,
PassOwnPtr<protocol::Array<protocol::Debugger::BlackboxPattern>> patterns)
override;
On 2016/03/04 20:22:39, pfeldman wrote:
> setBlackboxPatterns

Replaced with add and clear.

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/protocol.json:3817: "name":
"editBlackboxPatterns",
On 2016/03/04 20:22:39, pfeldman wrote:
> To recap: setBlackboxPatterns receives array of either hash or url or regex.
> Sames goes for setBreakpoint, setBreakpointById is not being used anymore.

I will add hash support for breakpoints in separated CL.

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
(right):

https://codereview.chromium.org/1754483002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h:293:
HashSet<String> m_loadedScriptHashes;
On 2016/03/04 20:22:39, pfeldman wrote:
> Should this be a map?

It should be nothing. Removed.

[kozy, 2016-03-06 01:16:06]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-06 01:16:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754483002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754483002/160001

[commit-bot: I haz the power, 2016-03-06 02:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-06 02:26:41]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-03-07 17:26:14]

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:13:
WebInspector.targetManager.observeTargets(this);
Better do this at the end, after all fields have been initialized.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:303:
promises.push(this._addBlackboxPatterns(debuggerModel));
Clear patterns before adding them again.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:1018: * @param
{string=} hash
Move it down the list to align with DebuggerModel.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/protocol.json:3808: "description": "Makes
backend skip steps in the script in blackboxed ranges. VM will try leave
blacklisted scripts by performing 'step in' several times, finally resorting to
'step out' if unsuccessful. Positions array contains positions where blackbox
state is changed. First interval isn't blackboxed. Array should be sorted."
Please move detailed description of positions to BlackboxPattern.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:114:
*error = "Position missing 'line' or 'line' < 0.";
Can't be missing anymore.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:600:
Vector<std::pair<int, int>> emptyPositions;
Unused.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:609:
m_scriptToBlackboxPositions.set(script.sourceURL(),
protocol::Vector<std::pair<int, int>>(1));
What is this Vector(1)? Not at all understandable.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1319:
scriptToBlackboxPositions.set(url.isEmpty() ? hash : url, positions);
Won't url and hash collide?

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1335:
void V8DebuggerAgentImpl::clearBlackboxPatterns(ErrorString* error)
Should remove from m_state as well.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1639:
m_scriptToBlackboxPositions.clear();
Forgot to |m_blackboxRegexpPattern = String()|

[pfeldman, 2016-03-07 19:22:47]

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/protocol.json:3805: { "name": "patterns",
"type": "array", "items": { "$ref": "BlackboxPattern"} }
Why is the add/clear contract? It is typically either add/remove or set/clear.

[kozy, 2016-03-08 02:33:21]

All done!

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:13:
WebInspector.targetManager.observeTargets(this);
On 2016/03/07 17:26:13, dgozman wrote:
> Better do this at the end, after all fields have been initialized.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:303:
promises.push(this._addBlackboxPatterns(debuggerModel));
On 2016/03/07 17:26:13, dgozman wrote:
> Clear patterns before adding them again.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:1018: * @param
{string=} hash
On 2016/03/07 17:26:13, dgozman wrote:
> Move it down the list to align with DebuggerModel.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/protocol.json:3805: { "name": "patterns",
"type": "array", "items": { "$ref": "BlackboxPattern"} }
On 2016/03/07 19:22:47, pfeldman wrote:
> Why is the add/clear contract? It is typically either add/remove or set/clear.

I'd like to set initial pattern on debugger enable then add patterns on events
like source map loaded and then clear all patterns on pattern changed. We've
discussed this API in offline discussion with @dgozman.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/protocol.json:3808: "description": "Makes
backend skip steps in the script in blackboxed ranges. VM will try leave
blacklisted scripts by performing 'step in' several times, finally resorting to
'step out' if unsuccessful. Positions array contains positions where blackbox
state is changed. First interval isn't blackboxed. Array should be sorted."
On 2016/03/07 17:26:13, dgozman wrote:
> Please move detailed description of positions to BlackboxPattern.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:114:
*error = "Position missing 'line' or 'line' < 0.";
On 2016/03/07 17:26:14, dgozman wrote:
> Can't be missing anymore.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:600:
Vector<std::pair<int, int>> emptyPositions;
On 2016/03/07 17:26:14, dgozman wrote:
> Unused.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:609:
m_scriptToBlackboxPositions.set(script.sourceURL(),
protocol::Vector<std::pair<int, int>>(1));
On 2016/03/07 17:26:14, dgozman wrote:
> What is this Vector(1)? Not at all understandable.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1319:
scriptToBlackboxPositions.set(url.isEmpty() ? hash : url, positions);
On 2016/03/07 17:26:14, dgozman wrote:
> Won't url and hash collide?

Yes, they can collide.
Added a prefix to each entry in map on backend.
With prefix it can collide too but probability of this event is very low.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1335:
void V8DebuggerAgentImpl::clearBlackboxPatterns(ErrorString* error)
On 2016/03/07 17:26:14, dgozman wrote:
> Should remove from m_state as well.

Done.

https://codereview.chromium.org/1754483002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1639:
m_scriptToBlackboxPositions.clear();
On 2016/03/07 17:26:14, dgozman wrote:
> Forgot to |m_blackboxRegexpPattern = String()|

Done.

[kozy, 2016-03-08 02:33:32]

Patchset #6 (id:180001) has been deleted

[dgozman, 2016-03-08 18:48:12]

Please follow up with addChangeListener and breakpoints by hash.

lgtm with comments

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackbox-ranges.html
(right):

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackbox-ranges.html:30:
scriptIdToPattern.set(response.params.scriptId, response.params.hasSourceURL ? {
url: response.params.url } : { hash: response.params.hash });
hasSourceURL looks suspicious.

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:302:
promises.push(clearBlackboxPatterns(debuggerModel).then(addBlackboxPatterns.bind(this,
debuggerModel)));
This should go before _addScript calls.

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:322:
return debuggerModel.clearBlackboxPatterns();
Inline it!

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:333: if
(!wasCleared)
Ignore this and inline.

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:645: return
new Promise(addBlackboxPatterns.bind(this));
Let's use lushnikov's wisdom:

var promiseCallback;
this._agent.....
return new Promise(fullfill => promiseCallback = fullfill);

....
promiseCallback(!error)

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:312: var pattern =
this.hasSourceURL ? { url: this.sourceURL } : { hash: this._hash };
hasSourceURL is suspicious

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:606:
auto itBlackboxHash = m_scriptToBlackboxPositions.find(script.hasSourceURL() ?
urlPrefix + script.url() : hashPrefix + script.hash());
I think it's not worth to add strings in this hot function. Let's forget about
collisions.

https://codereview.chromium.org/1754483002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:611:
protocol::Vector<std::pair<int, int>> blackboxedSourcePositions(1);
Explicit.

[kozy, 2016-04-19 21:46:30]

We choose another approach to go with:
https://codereview.chromium.org/1902993002/