 Chromium Code Reviews
 Chromium Code Reviews Issue 1754473002:
  MD Settings: create a global "action button" style (blue, flat)  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1754473002:
  MD Settings: create a global "action button" style (blue, flat)  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 <link rel="import" href="chrome://resources/html/polymer_config.html"> | 1 <link rel="import" href="chrome://resources/html/polymer_config.html"> | 
| 2 <link rel="import" href="chrome://md-settings/i18n_setup.html"> | 2 <link rel="import" href="chrome://md-settings/i18n_setup.html"> | 
| 3 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html"> | 3 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines _browser_proxy.html"> | 
| 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> | 
| 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog/paper-dial og.html"> | 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog/paper-dial og.html"> | 
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | 
| 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> | 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> | 
| 8 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 8 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 
| 9 <link rel="import" href="chrome://md-settings/settings_dialog_css.html"> | 9 <link rel="import" href="chrome://md-settings/settings_dialog_css.html"> | 
| 10 <link rel="import" href="chrome://md-settings/settings_shared_css.html"> | |
| 10 | 11 | 
| 11 <dom-module id="settings-search-engine-dialog"> | 12 <dom-module id="settings-search-engine-dialog"> | 
| 12 <template> | 13 <template> | 
| 13 <style include="settings-dialog"></style> | 14 <style include="settings-dialog"></style> | 
| 15 <style include="settings-shared"></style> | |
| 
dpapad
2016/03/01 02:18:03
Are you planning to split settings-shared more in
 
Dan Beam
2016/03/01 17:44:04
not until performance or maintainability fail to s
 | |
| 14 <paper-dialog modal id="dialog"> | 16 <paper-dialog modal id="dialog"> | 
| 15 <div id="dialog-content"> | 17 <div id="dialog-content"> | 
| 16 <div class="top-row"> | 18 <div class="top-row"> | 
| 17 <span class="title">[[dialogTitle_]]</span> | 19 <span class="title">[[dialogTitle_]]</span> | 
| 18 <paper-icon-button icon="clear" on-tap="cancel_" id="close"> | 20 <paper-icon-button icon="clear" on-tap="cancel_" id="close"> | 
| 19 </paper-icon-button> | 21 </paper-icon-button> | 
| 20 </div> | 22 </div> | 
| 21 <div class="body"> | 23 <div class="body"> | 
| 22 <div class="explanation"> | 24 <div class="explanation"> | 
| 23 <paper-input always-float-label id="searchEngine" | 25 <paper-input always-float-label id="searchEngine" | 
| 24 i18n-values="label:searchEnginesSearchEngine;error-message:searc hEnginesNotValid" | 26 i18n-values="label:searchEnginesSearchEngine;error-message:searc hEnginesNotValid" | 
| 25 value="{{searchEngine_}}" on-focus="validate_" | 27 value="{{searchEngine_}}" on-focus="validate_" | 
| 26 on-input="validate_"> | 28 on-input="validate_"> | 
| 27 </paper-input> | 29 </paper-input> | 
| 28 <paper-input always-float-label id="keyword" | 30 <paper-input always-float-label id="keyword" | 
| 29 i18n-values="label:searchEnginesKeyword;error-message:searchEngi nesNotValid" | 31 i18n-values="label:searchEnginesKeyword;error-message:searchEngi nesNotValid" | 
| 30 value="{{keyword_}}" on-focus="validate_" on-input="validate_"> | 32 value="{{keyword_}}" on-focus="validate_" on-input="validate_"> | 
| 31 </paper-input> | 33 </paper-input> | 
| 32 <paper-input always-float-label id="queryUrl" | 34 <paper-input always-float-label id="queryUrl" | 
| 33 i18n-values="label:searchEnginesQueryURLExplanation;error-messag e:searchEnginesNotValid" | 35 i18n-values="label:searchEnginesQueryURLExplanation;error-messag e:searchEnginesNotValid" | 
| 34 value="{{queryUrl_}}" on-focus="validate_" on-input="validate_" | 36 value="{{queryUrl_}}" on-focus="validate_" on-input="validate_" | 
| 35 disabled$="[[model.urlLocked]]"> | 37 disabled$="[[model.urlLocked]]"> | 
| 36 </paper-input> | 38 </paper-input> | 
| 37 </div> | 39 </div> | 
| 38 <div class="button-container"> | 40 <div class="button-container"> | 
| 39 <paper-button class="cancel-button" on-tap="cancel_" | 41 <paper-button class="cancel-button" on-tap="cancel_" | 
| 40 i18n-content="cancel" id="cancel"></paper-button> | 42 i18n-content="cancel" id="cancel"></paper-button> | 
| 41 <paper-button id="actionButton" class="action-button" | 43 <paper-button id="actionButton" class="call-to-action" | 
| 42 on-tap="onActionButtonTap_"> | 44 on-tap="onActionButtonTap_"> | 
| 43 [[actionButtonText_]] | 45 [[actionButtonText_]] | 
| 44 </paper-button> | 46 </paper-button> | 
| 45 </div> | 47 </div> | 
| 46 </div> | 48 </div> | 
| 47 </div> | 49 </div> | 
| 48 </paper-dialog> | 50 </paper-dialog> | 
| 49 </template> | 51 </template> | 
| 50 <script src="search_engine_dialog.js"></script> | 52 <script src="search_engine_dialog.js"></script> | 
| 51 </dom-module> | 53 </dom-module> | 
| OLD | NEW |