Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1754453002: Change preload's as values audio/video to media (Closed)

Created:
4 years, 9 months ago by Yoav Weiss
Modified:
4 years, 9 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change preload's as values audio/video to media The spec was changed. This CL aligns the implementation with the spec. BUG=593905 Committed: https://crrev.com/b93eb5b19fbe47b7c0e24d371db6dd2a219c8c94 Cr-Commit-Position: refs/heads/master@{#380588}

Patch Set 1 #

Patch Set 2 : rebase and test alignment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/preload/download_resources.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/onload_event.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/single_download_preload.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 1 chunk +7 lines, -6 lines 2 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yoav Weiss
Hey Nate :) Can you take a look?
4 years, 9 months ago (2016-03-10 21:54:21 UTC) #3
Nate Chapin
lgtm https://codereview.chromium.org/1754453002/diff/20001/third_party/WebKit/Source/core/loader/LinkLoader.cpp File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right): https://codereview.chromium.org/1754453002/diff/20001/third_party/WebKit/Source/core/loader/LinkLoader.cpp#newcode174 third_party/WebKit/Source/core/loader/LinkLoader.cpp:174: ASSERT(as.lower() == as); Was this always true?
4 years, 9 months ago (2016-03-10 22:49:05 UTC) #4
Yoav Weiss
https://codereview.chromium.org/1754453002/diff/20001/third_party/WebKit/Source/core/loader/LinkLoader.cpp File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right): https://codereview.chromium.org/1754453002/diff/20001/third_party/WebKit/Source/core/loader/LinkLoader.cpp#newcode174 third_party/WebKit/Source/core/loader/LinkLoader.cpp:174: ASSERT(as.lower() == as); On 2016/03/10 22:49:05, Nate Chapin wrote: ...
4 years, 9 months ago (2016-03-10 23:12:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754453002/20001
4 years, 9 months ago (2016-03-10 23:13:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129087)
4 years, 9 months ago (2016-03-11 00:33:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754453002/20001
4 years, 9 months ago (2016-03-11 08:13:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 09:47:08 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 09:48:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b93eb5b19fbe47b7c0e24d371db6dd2a219c8c94
Cr-Commit-Position: refs/heads/master@{#380588}

Powered by Google App Engine
This is Rietveld 408576698