Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 175433002: Revert of ARM Skia NEON patches - 12 - S32_Blend (Closed)

Created:
6 years, 10 months ago by scroggo
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of ARM Skia NEON patches - 12 - S32_Blend (https://codereview.chromium.org/158973002/) Reason for revert: Breaking the build. See http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-Nexus4/builds/2966 (and others). We are getting warnings that vsrc and vdst may be uninitialized. Please fix and resubmit. Original issue's description: > ARM Skia NEON patches - 12 - S32_Blend > > Blitrow32: S32_Blend fix and little speed improvement > > - the results are now exactly similar as the C code > - the speed has improved, especially for small values of count > > +-------+-----------+------------+ > | count | Cortex-A9 | Cortex-A15 | > +-------+-----------+------------+ > | 1 | +30% | +18% | > +-------+-----------+------------+ > | 2 | 0 | 0 | > +-------+-----------+------------+ > | 4 | - <1% | +14% | > +-------+-----------+------------+ > | > 4 | -0.5..+5% | -0.5..+4% | > +-------+-----------+------------+ > > Signed-off-by: Kévin PETIT <kevin.petit@arm.com>; > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=13532 TBR=djsollen@google.com,mtklein@google.com,kevin.petit@arm.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -64 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +66 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of ARM Skia NEON patches - 12 - S32_Blend
6 years, 10 months ago (2014-02-21 17:52:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/175433002/1
6 years, 10 months ago (2014-02-21 17:52:14 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 17:52:20 UTC) #3
Message was sent while issue was closed.
Change committed as 13534

Powered by Google App Engine
This is Rietveld 408576698