Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1754313002: Simplify the shutdown sequence of Oilpan's heap (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
keishi, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the shutdown sequence of Oilpan's heap The current shutdown sequence is more complicated than necessary since it was implemented in days when it was not guaranteed that the main thread is the last thread that gets detached. Today the main thread joins all other threads before calling Heap::shutdown(), so we can assume that the main thread is the last thread that gets detached. This CL simplifies the shutdown sequence relying on the assumption. BUG= Committed: https://crrev.com/3ae8ad9e6ddbfe21e31d889d4ce622a3ab09929d Cr-Commit-Position: refs/heads/master@{#379766}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 3 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 3 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-02 16:28:10 UTC) #2
sof
(Release assert added in Heap.cpp is triggering.)
4 years, 9 months ago (2016-03-02 18:14:29 UTC) #3
haraken
Now the tests pass. PTAL.
4 years, 9 months ago (2016-03-08 05:58:38 UTC) #4
sof
lgtm (pointer event breakage non-Oilpan, but unrelated.)
4 years, 9 months ago (2016-03-08 06:10:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754313002/60001
4 years, 9 months ago (2016-03-08 06:11:02 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-08 06:18:36 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3ae8ad9e6ddbfe21e31d889d4ce622a3ab09929d Cr-Commit-Position: refs/heads/master@{#379766}
4 years, 9 months ago (2016-03-08 06:19:50 UTC) #10
haraken
4 years, 9 months ago (2016-03-10 01:13:23 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1783673002/ by haraken@chromium.org.

The reason for reverting is: 
https://chromium.googlesource.com/chromium/src/+/5940f25b9d91258d698a5ce9f48e...
caused the following crash:

https://bugs.chromium.org/p/chromium/issues/detail?id=593092

This CL needs to be reverted to revert the above CL.
.

Powered by Google App Engine
This is Rietveld 408576698