Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 17543004: Allow the same version plugin to be loaded multiple times on Windows. (Closed)

Created:
7 years, 6 months ago by pastarmovj
Modified:
7 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Allow the same version plugin to be loaded multiple times on Windows. Resolves the issue of using a plugin installed through an extension in more than one profile. BUG=132894 TEST=Install an extension with plugin in two profiles and observe it works (e.g. Legacy Browser Support) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207869

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverted comment change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/plugins/npapi/plugin_list_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pastarmovj
Please review this CL. I verified that it indeed fixes the issue for my extension. ...
7 years, 6 months ago (2013-06-21 09:28:38 UTC) #1
Bernhard Bauer
LGTM with a nit: https://codereview.chromium.org/17543004/diff/1/webkit/plugins/npapi/plugin_list_win.cc File webkit/plugins/npapi/plugin_list_win.cc (right): https://codereview.chromium.org/17543004/diff/1/webkit/plugins/npapi/plugin_list_win.cc#newcode394 webkit/plugins/npapi/plugin_list_win.cc:394: return false; // We have ...
7 years, 6 months ago (2013-06-21 09:34:12 UTC) #2
pastarmovj
https://codereview.chromium.org/17543004/diff/1/webkit/plugins/npapi/plugin_list_win.cc File webkit/plugins/npapi/plugin_list_win.cc (right): https://codereview.chromium.org/17543004/diff/1/webkit/plugins/npapi/plugin_list_win.cc#newcode394 webkit/plugins/npapi/plugin_list_win.cc:394: return false; // We have already loaded a plugin ...
7 years, 6 months ago (2013-06-21 11:20:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/17543004/6001
7 years, 6 months ago (2013-06-21 11:25:01 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 17:04:13 UTC) #5
Message was sent while issue was closed.
Change committed as 207869

Powered by Google App Engine
This is Rietveld 408576698