Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1754253002: dart2js cps: Bugfix in insert refinement pass. (Closed)

Created:
4 years, 9 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Bugfix in insert refinement pass. The insert refinements pass would refine the interceptor instead of the Dart receiver, when the interceptor is the "this" parameter. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/8c1475f186bb1fd59110ebb2e199de3111d1c261

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 9 months ago (2016-03-03 11:45:04 UTC) #2
Kevin Millikin (Google)
Good catch. LGTM.
4 years, 9 months ago (2016-03-03 12:28:44 UTC) #3
asgerf
4 years, 9 months ago (2016-03-03 12:49:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8c1475f186bb1fd59110ebb2e199de3111d1c261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698