Retain image sizes

javatests/org/chromium/distiller/EmbedExtractorTest.java

Index: javatests/org/chromium/distiller/EmbedExtractorTest.java
diff --git a/javatests/org/chromium/distiller/EmbedExtractorTest.java b/javatests/org/chromium/distiller/EmbedExtractorTest.java
index b68f52eeb826d3297651dd1b079bc127d1387302..7a66f0d2e645b53e946adf1da890f2091b75890d 100644
--- a/javatests/org/chromium/distiller/EmbedExtractorTest.java
+++ b/javatests/org/chromium/distiller/EmbedExtractorTest.java
@@ -5,14 +5,17 @@
 package org.chromium.distiller;
 
 import org.chromium.distiller.webdocument.WebEmbed;
+import org.chromium.distiller.webdocument.WebImage;
 import org.chromium.distiller.extractors.embeds.EmbedExtractor;
 import org.chromium.distiller.extractors.embeds.TwitterExtractor;
 import org.chromium.distiller.extractors.embeds.VimeoExtractor;
 import org.chromium.distiller.extractors.embeds.YouTubeExtractor;
+import org.chromium.distiller.extractors.embeds.ImageExtractor;
 
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.IFrameElement;
+import com.google.gwt.dom.client.ImageElement;
 
 import java.util.List;
 
@@ -200,4 +203,32 @@ public class EmbedExtractorTest extends DomDistillerJsTestCase {
         result = (WebEmbed) extractor.extract(notTwitter);
         assertNull(result);
     }
+
+    public void testImageExtractorWithWidthHeightAttributes() {
+        ImageElement image = TestUtil.createImage();
+        image.setSrc("http://www.test.com/image.jpg");
+        image.setAttribute("width", "32");
+        image.setAttribute("height", "32");
+
+        EmbedExtractor extractor = new ImageExtractor();
+        WebImage result = (WebImage) extractor.extract(image);
+
+        assertNotNull(result);
+        assertEquals("http://www.test.com/image.jpg", result.getSrc());
+        assertEquals(32, result.getWidth());
+        assertEquals(32, result.getHeight());
+    }
+
+    public void testImageExtractorWithOneAttribute() {
+        ImageElement image = TestUtil.createImage();
+        image.setSrc("http://www.test.com/image.jpg");
+        image.setAttribute("width", "32");
+
+        EmbedExtractor extractor = new ImageExtractor();
+        WebImage result = (WebImage) extractor.extract(image);
+        assertNotNull(result);
+        assertEquals("http://www.test.com/image.jpg", result.getSrc());
+        assertEquals(32, result.getWidth());
+        assertEquals(0, result.getHeight());

[wychen, 2016/03/11 08:25:35]

We need to keep aspect ratio.

[dalmirsilva, 2016/03/14 18:28:06]

Aspect ratio will be kept. However, we could not reproduce it in Unit Test 
because it doesn't behave as the real DOM.
In order to avoid confusion maybe we could just remove this assert.
Do you have any suggestions on this?

[wychen, 2016/03/14 19:55:14]

If it is not possible to test here, we can add browsertests in chrome. You can
find some examples here:
https://code.google.com/p/chromium/codesearch#search/&q=dom%20distiller%20bro...

We'd like to at least cover cases like no dimension specified, (both/only one)
of {width, height} attributes, specified by CSS in px, %, other units, and
probably some more complicated cases.

+    }
 }