Retain image sizes

java/org/chromium/distiller/extractors/embeds/ImageExtractor.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.distiller.extractors.embeds;
 
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.ImageElement;
 import org.chromium.distiller.webdocument.WebImage;
 
@@ skipping 15 matching lines @@
     public Set<String> getRelevantTagNames() {
         return relevantTags;
     }
 
     @Override
     public WebImage extract(Element e) {
         if (!relevantTags.contains(e.getTagName())) {
             return null;
         }
         String imgSrc = "";
+        int width = e.getOffsetWidth();
+        int height = e.getOffsetHeight();

[wychen, 2016/03/11 08:25:35]

offsetWidth/Height would be affected by padding, but I guess this might be a
reasonable default if we can handle tags other than img.
Might worth noting this in the comment.

[dalmirsilva, 2016/03/14 18:28:06]

Done.

         if ("IMG".equals(e.getTagName())) {
-            // This will get the absolute URL of the image.
-            imgSrc = ImageElement.as(e).getSrc();
+            // This will get the absolute URL of the image and
+            // the real image dimension.
+            ImageElement imageElement = ImageElement.as(e);
+            imgSrc = imageElement.getSrc();
+            width = imageElement.getWidth();

[wychen, 2016/03/11 08:25:35]

What if the dimension specified in CSS is different? Have you considered using
computed style instead of width/height attributes?

I can see the argument on both sides. Some sites load images only when it's
close to the view port, and I'm not sure how well this works for those
late-loading images.

[wychen, 2016/03/11 08:25:35]

If only width or height is specified, the other one would be derived so that the
aspect ratio remains the same. We need to honor that.

[dalmirsilva, 2016/03/14 18:28:05]

We believe GWT uses getWidth/Height as native methods. 
And by its definition: 
"This property can also return the width of an image that has been styled with
CSS."
See more here: http://www.w3schools.com/jsref/prop_img_width.asp.
Therefore, both properties should preserve the image aspect ratio and are,
already,
computed by the browser.

+            height = imageElement.getHeight();
         }
 
-        return new WebImage(e, e.getOffsetWidth(), e.getOffsetHeight(), imgSrc);
+        return new WebImage(e, width, height, imgSrc);
     }
 }