Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: java/org/chromium/distiller/webdocument/WebImage.java

Issue 1754213004: Retain image sizes (Closed) Base URL: https://github.com/chromium/dom-distiller.git@master
Patch Set: comments addressed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.distiller.webdocument; 5 package org.chromium.distiller.webdocument;
6 6
7 import com.google.gwt.dom.client.Document; 7 import com.google.gwt.dom.client.Document;
8 import com.google.gwt.dom.client.Element; 8 import com.google.gwt.dom.client.Element;
9 import com.google.gwt.dom.client.ImageElement; 9 import com.google.gwt.dom.client.ImageElement;
10 10
(...skipping 28 matching lines...) Expand all
39 srcUrl = ""; 39 srcUrl = "";
40 } 40 }
41 } 41 }
42 42
43 @Override 43 @Override
44 public String generateOutput(boolean textOnly) { 44 public String generateOutput(boolean textOnly) {
45 if (textOnly) return ""; 45 if (textOnly) return "";
46 46
47 ImageElement ie = ImageElement.as(Element.as(imgElement.cloneNode(false) )); 47 ImageElement ie = ImageElement.as(Element.as(imgElement.cloneNode(false) ));
48 ie.setSrc(ie.getSrc()); 48 ie.setSrc(ie.getSrc());
49 // If computed width or height is zero, do not override them
50 // to keep them visible.
51 if (width > 0 && height > 0) {
52 ie.setWidth(width);
53 ie.setHeight(height);
54 }
49 DomUtil.makeSrcSetAbsolute(ie); 55 DomUtil.makeSrcSetAbsolute(ie);
50 DomUtil.stripImageElement(ie); 56 DomUtil.stripImageElement(ie);
51 57
52 Element container = Document.get().createDivElement(); 58 Element container = Document.get().createDivElement();
53 container.appendChild(ie); 59 container.appendChild(ie);
54 return container.getInnerHTML(); 60 return container.getInnerHTML();
55 } 61 }
56 62
57 /** 63 /**
58 * Get the image element of this WebImage. 64 * Get the image element of this WebImage.
(...skipping 20 matching lines...) Expand all
79 } 85 }
80 86
81 /** 87 /**
82 * Get the source URL of this image. 88 * Get the source URL of this image.
83 * @return Source URL or an empty string. 89 * @return Source URL or an empty string.
84 */ 90 */
85 public String getSrc() { 91 public String getSrc() {
86 return srcUrl; 92 return srcUrl;
87 } 93 }
88 } 94 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698