Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issue 1754213003: Remove code for deprecated and rotted histogram. (Closed)

Created:
4 years, 9 months ago by Bryan McQuade
Modified:
4 years, 9 months ago
CC:
jochen (gone - plz use gerrit), blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, marja
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code for deprecated and rotted histogram. WebCore.Scripts.ParsingBlocking.TimeBetweenLoadedAndCompiled is marked as deprecated in histograms.xml (see https://chromium.googlesource.com/chromium/src/+/68cde75708853730a1881142d330d573194dc3e4), but we still have code checked in to report it. The code has also rotted. For example, the code for this histogram depends on the state of a boolean member added to HTMLScriptRunner that's always false. BUG=591399 Committed: https://crrev.com/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6 Cr-Commit-Position: refs/heads/master@{#378926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 5 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Bryan McQuade
Kinuko, PTAL. Just removing some unused histogram code. Jochen, Marja, based on my reading of ...
4 years, 9 months ago (2016-03-02 17:30:29 UTC) #2
jochen (gone - plz use gerrit)
+vogelheim is that correct that we don't need those histograms anymore?
4 years, 9 months ago (2016-03-02 17:39:51 UTC) #6
vogelheim
On 2016/03/02 17:39:51, jochen wrote: > +vogelheim > > is that correct that we don't ...
4 years, 9 months ago (2016-03-02 17:46:38 UTC) #7
Bryan McQuade
On 2016/03/02 at 17:46:38, vogelheim wrote: > On 2016/03/02 17:39:51, jochen wrote: > > +vogelheim ...
4 years, 9 months ago (2016-03-02 21:46:14 UTC) #8
kinuko
lgtm per discussion
4 years, 9 months ago (2016-03-03 02:22:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754213003/1
4 years, 9 months ago (2016-03-03 02:39:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 02:44:43 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 02:46:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6
Cr-Commit-Position: refs/heads/master@{#378926}

Powered by Google App Engine
This is Rietveld 408576698