Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1754113003: Revert of Fix SkTwoPointConicalGradient zero-radius handling (Closed)

Created:
4 years, 9 months ago by fmalita_google_do_not_use
Modified:
4 years, 9 months ago
Reviewers:
f(malita), caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix SkTwoPointConicalGradient zero-radius handling (patchset #2 id:20001 of https://codereview.chromium.org/1756573002/ ) Reason for revert: One layout test shows a regression: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/83359/layout-test-results/fast/gradients/crash-on-zero-radius-diffs.html Original issue's description: > Fix SkTwoPointConicalGradient zero-radius handling > > r == 0 is within valid gradient range, we shouldn't skip it. > > BUG=skia:5023 > R=caryclark@google.com,reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756573002 > > Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 TBR=caryclark@google.com,reed@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5023 Committed: https://skia.googlesource.com/skia/+/734949099166f7bc446a352ce3596dc009484f59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GradientTest.cpp View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
fmalita_google_do_not_use
Created Revert of Fix SkTwoPointConicalGradient zero-radius handling
4 years, 9 months ago (2016-03-02 14:34:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754113003/1
4 years, 9 months ago (2016-03-02 14:34:18 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:34:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/734949099166f7bc446a352ce3596dc009484f59

Powered by Google App Engine
This is Rietveld 408576698