Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1754093002: Use GURLs instead of patterns in SetContentSetting in mic and camera (Closed)

Created:
4 years, 9 months ago by lshang
Modified:
4 years, 9 months ago
Reviewers:
raymes, xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GURLs instead of patterns in SetContentSetting in mic and camera Use SetContentSettingDefaultScope() which takes GURLs directly for CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC/CAMERA. BUG=551747 Committed: https://crrev.com/909753cb33ff76ec0b0b39e54c571a075cc0e88c Cr-Commit-Position: refs/heads/master@{#379681}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M chrome/browser/media/media_stream_devices_controller.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller_browsertest.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
lshang
PTAL thanks!
4 years, 9 months ago (2016-03-03 03:18:11 UTC) #3
raymes
lgtm
4 years, 9 months ago (2016-03-07 01:22:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754093002/20001
4 years, 9 months ago (2016-03-07 03:40:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/153782)
4 years, 9 months ago (2016-03-07 03:49:18 UTC) #9
lshang
+OWNER xhwang@, please review changes in: chrome/browser/media/ thanks!
4 years, 9 months ago (2016-03-07 03:59:24 UTC) #11
xhwang
LGTM
4 years, 9 months ago (2016-03-07 17:52:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754093002/20001
4 years, 9 months ago (2016-03-07 23:05:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 23:21:53 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 23:23:13 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/909753cb33ff76ec0b0b39e54c571a075cc0e88c
Cr-Commit-Position: refs/heads/master@{#379681}

Powered by Google App Engine
This is Rietveld 408576698