Migrate old settings for ContentSettingTypes with wildcard as secondary_pattern

chrome/browser/ssl/chrome_ssl_host_state_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h"
 
 #include <stdint.h>
 
 #include <set>
 
@@ skipping 91 matching lines @@
   // lookups using GetWebsiteSetting (because Wildcard matches everything) but
   // it has an impact when trying to change the existing content setting. We
   // need to migrate the old-format keys.
   // TODO(raymes): Remove this after ~M51 when clients have migrated. We should
   // leave in some code to remove old-format settings for a long time.
   // crbug.com/569734.
   ContentSettingsForOneType settings;
   map->GetSettingsForOneType(CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS,
                              std::string(), &settings);
   for (const ContentSettingPatternSource& setting : settings) {
+    // Migrate user preference settings only.
+    if (setting.source != "preference")

[jww, 2016/03/31 18:05:31]

Should probable be:
if (setting.source != site_settings::kPreferencesSource) {
(see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...)

Also, should an error be logged in this case? I don't quite see how it would get
to this state otherwise.

[raymes, 2016/04/03 23:40:19]

I think there could be other settings in this list, such as the default setting.

+      continue;
     // Migrate old-format settings only.
     if (setting.secondary_pattern != ContentSettingsPattern::Wildcard()) {
       GURL url(setting.primary_pattern.ToString());
       // Pull out the value of the old-format setting. Only do this if the
       // patterns are as we expect them to be, otherwise the setting will just
       // be removed for safety.
       scoped_ptr<base::Value> value;
       if (setting.primary_pattern == setting.secondary_pattern &&
           url.is_valid()) {
         value = map->GetWebsiteSetting(url, url,
@@ skipping 315 matching lines @@
 }
 
 bool ChromeSSLHostStateDelegate::DidHostRunInsecureContent(
     const std::string& host,
     int pid) const {
   return !!ran_insecure_content_hosts_.count(BrokenHostEntry(host, pid));
 }
 void ChromeSSLHostStateDelegate::SetClock(scoped_ptr<base::Clock> clock) {
   clock_.reset(clock.release());
 }