ScrollableArea::pixelStep should return DIP not viewport (physical pixels)

ScrollableArea::pixelStep should return DIP not viewport (not pysical pixels)

* The test is currently for the new mode only. I'll work on
moving event scaling logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html

Committed: https://crrev.com/e931e57f2587458f35852035ba7afc526989d127
Cr-Commit-Position: refs/heads/master@{#379085}

[oshima, 2016-03-02 01:08:40]

Description was changed from

==========
ScrollableArea::pixelStep should return physical pixel not DIP

BUG=588233
==========

to

==========
ScrollableArea::pixelStep should return physical pixel not DIP

BUG=588233
TEST=TBD.
==========

[tdresser, 2016-03-02 18:29:53]

tdresser@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2016-03-02 18:29:53]

This does fix the bug.

Tested on link.

[oshima, 2016-03-02 18:34:34]

On 2016/03/02 18:29:53, tdresser wrote:
> This does fix the bug.
> 
> Tested on link.

Thanks. I'll work on a test.

[oshima, 2016-03-03 14:18:14]

Description was changed from

==========
ScrollableArea::pixelStep should return physical pixel not DIP

BUG=588233
TEST=TBD.
==========

to

==========
ScrollableArea::pixelStep should return physical pixel not DIP

* The test is currently for the new mode only. I'll work on moving event scaling
logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

[oshima, 2016-03-03 14:18:19]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 14:18:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754033002/20001

[commit-bot: I haz the power, 2016-03-03 15:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 15:35:23]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-03-03 15:50:31]

Description was changed from

==========
ScrollableArea::pixelStep should return physical pixel not DIP

* The test is currently for the new mode only. I'll work on moving event scaling
logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

to

==========
ScrollableArea::pixelStep should return physical pixel

* The test is currently for the new mode only. I'll work on moving event scaling
logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

[oshima, 2016-03-03 15:50:31]

Description was changed from

==========
ScrollableArea::pixelStep should return physical pixel not DIP

* The test is currently for the new mode only. I'll work on moving event scaling
logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

to

==========
ScrollableArea::pixelStep should return physical pixel

* The test is currently for the new mode only. I'll work on moving event scaling
logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

[oshima, 2016-03-03 15:51:05]

Description was changed from

==========
ScrollableArea::pixelStep should return physical pixel

* The test is currently for the new mode only. I'll work on moving event scaling
logic to EventSender and enable test in old mode in a separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

to

==========
ScrollableArea::pixelStep should return DIP not viewport

* The test is currently for the new mode only. I'll work on 
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

[oshima, 2016-03-03 15:58:33]

Description was changed from

==========
ScrollableArea::pixelStep should return DIP not viewport

* The test is currently for the new mode only. I'll work on 
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

to

==========
ScrollableArea::pixelStep should return DIP not viewport (not pysical pixels)

* The test is currently for the new mode only. I'll work on 
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

[oshima, 2016-03-03 15:59:51]

PTAL

https://codereview.chromium.org/1754033002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1754033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:279: crbug.com/495750
virtual/scalefactor150/fast/hidpi/static/ [ NeedsRebaseline ]
The expectation for new tests will be generated if we can land this before
they're rebased. I'll add new lines if they're updated first.

[tdresser, 2016-03-03 16:21:51]

LGTM with nit.

https://codereview.chromium.org/1754033002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/hidpi/static/mousewheel-scroll-amount.html
(right):

https://codereview.chromium.org/1754033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/hidpi/static/mousewheel-scroll-amount.html:14:
description("This test ensures that mouse wheel ticks scrolls the right amount
pixels in high dpi mode.");
scrolls the right amount pixels -> 
scrolls the right number of pixels

[oshima, 2016-03-03 17:00:45]

https://codereview.chromium.org/1754033002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/hidpi/static/mousewheel-scroll-amount.html
(right):

https://codereview.chromium.org/1754033002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/hidpi/static/mousewheel-scroll-amount.html:14:
description("This test ensures that mouse wheel ticks scrolls the right amount
pixels in high dpi mode.");
On 2016/03/03 16:21:51, tdresser wrote:
> scrolls the right amount pixels -> 
> scrolls the right number of pixels

Done.

[oshima, 2016-03-03 17:04:35]

oshima@chromium.org changed reviewers:
+ eae@chromium.org

[oshima, 2016-03-03 17:04:36]

eae@ -> third_party/WebKit/Source owner

[eae, 2016-03-03 17:45:56]

LGTM

[oshima, 2016-03-03 17:54:27]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-03-03 17:54:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1754033002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-03 17:54:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754033002/40001

[commit-bot: I haz the power, 2016-03-03 20:58:57]

Description was changed from

==========
ScrollableArea::pixelStep should return DIP not viewport (not pysical pixels)

* The test is currently for the new mode only. I'll work on 
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

to

==========
ScrollableArea::pixelStep should return DIP not viewport (not pysical pixels)

* The test is currently for the new mode only. I'll work on 
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

[commit-bot: I haz the power, 2016-03-03 20:58:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-03 20:59:55]

Description was changed from

==========
ScrollableArea::pixelStep should return DIP not viewport (not pysical pixels)

* The test is currently for the new mode only. I'll work on 
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html
==========

to

==========
ScrollableArea::pixelStep should return DIP not viewport (not pysical pixels)

* The test is currently for the new mode only. I'll work on
moving event scaling logic to EventSender and enable test in old mode in a
separate CL.

BUG=588233
TEST=mousewheel-scroll-amount.html/gesture-scroll-amount.html

Committed: https://crrev.com/e931e57f2587458f35852035ba7afc526989d127
Cr-Commit-Position: refs/heads/master@{#379085}
==========

[commit-bot: I haz the power, 2016-03-03 20:59:56]

Patchset 3 (id:??) landed as
https://crrev.com/e931e57f2587458f35852035ba7afc526989d127
Cr-Commit-Position: refs/heads/master@{#379085}