Modify growth policy for table of canonical types in each class.

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 1204 matching lines @@
   __ popl(EAX);  // Pop argument (type arguments of object).
   __ popl(EAX);  // Pop argument (class of object).
   __ popl(EAX);  // Pop result (newly allocated object).
   // EAX: new object
   // Restore the frame pointer.
   __ LeaveFrame();
   __ ret();
 }
 
 
+// TODO(regis): This stub is not called anymore to allocate regular closures,
+// but only implicit instance closures. Simplify.

[Florian Schneider, 2014/02/24 09:29:00]

I noticed that as well after I changed the way regular closure are allocated to
allow allocation sinking: Use a AllocateObject + 2 * StoreInstanceField to
initialize the closure object.

I'm thinking about doing the same for instance closures so they also work with
allocation sinking. As a side-effect, this stub can be removed completely. What
do you think?

+
 // Called for inline allocation of closures.
 // Input parameters:
 //   ESP + 8 : receiver (null if not an implicit instance closure).
 //   ESP + 4 : type arguments object (null if class is no parameterized).
 //   ESP : points to return address.
 // Uses EAX, EBX, ECX, EDX as temporary registers.
 void StubCode::GenerateAllocationStubForClosure(Assembler* assembler,
                                                 const Function& func) {
   const Immediate& raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
@@ skipping 881 matching lines @@
   const Register temp = ECX;
   __ movl(left, Address(ESP, 2 * kWordSize));
   __ movl(right, Address(ESP, 1 * kWordSize));
   GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp);
   __ ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32