Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1753973002: sk_make_sp<T>() (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, reed1
CC:
mtklein, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

sk_make_sp<T>() because auto atm = sk_make_sp<SkAdvancedTypefaceMetrics>(); is better than sk_sp<SkAdvancedTypefaceMetrics> atm(new SkAdvancedTypefaceMetrics); GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753973002 Committed: https://skia.googlesource.com/skia/+/217c0b3f137d824413e806759bc25378abbe8c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M include/core/SkRefCnt.h View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/RefCntTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
hal.canary
PTAL
4 years, 9 months ago (2016-03-01 22:52:10 UTC) #3
mtklein
impl seems fine to me. taking myself out of any naming bikeshed...
4 years, 9 months ago (2016-03-01 23:00:04 UTC) #5
hal.canary
On 2016/03/01 at 23:00:04, mtklein wrote: > impl seems fine to me. taking myself out ...
4 years, 9 months ago (2016-03-01 23:16:46 UTC) #7
reed1
+bunge
4 years, 9 months ago (2016-03-02 01:37:01 UTC) #9
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-02 15:06:53 UTC) #10
reed1
api lgtm
4 years, 9 months ago (2016-03-02 15:29:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753973002/1
4 years, 9 months ago (2016-03-02 15:43:50 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:06:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/217c0b3f137d824413e806759bc25378abbe8c18

Powered by Google App Engine
This is Rietveld 408576698