Add codeOffset/codeLength properties to ElementImpl.

Add codeOffset/codeLength properties to ElementImpl.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/089e1ba737b5b505d4c0e02145c7e34191b79452

[Brian Wilkerson, 2016-03-02 00:08:09]

LGTM

https://codereview.chromium.org/1753963003/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/builder.dart (right):

https://codereview.chromium.org/1753963003/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/builder.dart:1354: void
_setCodeRange(ElementImpl element, AstNode node) {
Should / could this happen automatically in the 'forNode' constructors? If so,
it would prevent us from missing the necessary step. (It might cause a problem,
though, for ElementFactory.)

[scheglov, 2016-03-02 04:57:01]

https://codereview.chromium.org/1753963003/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/builder.dart (right):

https://codereview.chromium.org/1753963003/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/builder.dart:1354: void
_setCodeRange(ElementImpl element, AstNode node) {
On 2016/03/02 00:08:09, Brian Wilkerson wrote:
> Should / could this happen automatically in the 'forNode' constructors? If so,
> it would prevent us from missing the necessary step. (It might cause a
problem,
> though, for ElementFactory.)

Unfortunately it does not work well for constructors, where it is normal to have
"null" as a name.
And in general it seems that the idea of using forNode() was not very successful
- it mixes nodes with elements, and in result we get only barely initialized
element - just name and nothing else.

[scheglov, 2016-03-02 05:04:21]

Description was changed from

==========
Add codeOffset/codeLength properties to ElementImpl.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Add codeOffset/codeLength properties to ElementImpl.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/089e1ba737b5b505d4c0e02145c7e34191b79452
==========

[scheglov, 2016-03-02 05:04:23]

Committed patchset #1 (id:1) manually as
089e1ba737b5b505d4c0e02145c7e34191b79452 (presubmit successful).