Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1753933002: Add QUIC 31 in which the server's proof covers both the static server config as well as a hash of t… (Closed)

Created:
4 years, 9 months ago by danzh1
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@115244730
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add QUIC 31 in which the server's proof covers both the static server config as well as a hash of the client hello. This will allow the QUIC whitelist in Chrome to be removed. Merge internal change: 115261503 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove extra argument to fix build error. #

Patch Set 3 : Implement ProofVerifierChromium::VerifySignature(), but still fails tests #

Patch Set 4 : implement verify_source_chromium_open_ssl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -134 lines) Patch
M net/quic/crypto/crypto_protocol.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 7 chunks +15 lines, -7 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_utils.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_source.h View 3 chunks +11 lines, -4 lines 0 comments Download
M net/quic/crypto/proof_source_chromium.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_source_chromium_openssl.cc View 1 2 3 2 chunks +37 lines, -12 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 1 2 8 chunks +86 lines, -47 lines 0 comments Download
M net/quic/crypto/proof_verifier.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 1 2 3 8 chunks +29 lines, -6 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 8 chunks +22 lines, -15 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 7 chunks +7 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 14 chunks +22 lines, -7 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +18 lines, -13 lines 0 comments Download
M net/quic/quic_crypto_client_stream.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 7 chunks +10 lines, -5 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1753453003 Patch 1

Messages

Total messages: 3 (0 generated)
danzh1
4 years, 9 months ago (2016-03-01 21:18:44 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/1753933002/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/1753933002/diff/1/net/quic/quic_stream_factory.cc#newcode1573 net/quic/quic_stream_factory.cc:1573: cached->Initialize(server_info->state().server_config, Can you add: TODO(rch): figure out how ...
4 years, 9 months ago (2016-03-02 04:20:13 UTC) #2
Ryan Hamilton
4 years, 9 months ago (2016-03-02 21:03:55 UTC) #3 
On 2016/03/02 04:20:13, Ryan Hamilton wrote:
> lgtm
> 
>
https://codereview.chromium.org/1753933002/diff/1/net/quic/quic_stream_factor...
> File net/quic/quic_stream_factory.cc (right):
> 
>
https://codereview.chromium.org/1753933002/diff/1/net/quic/quic_stream_factor...
> net/quic/quic_stream_factory.cc:1573:
> cached->Initialize(server_info->state().server_config,
> Can you add:
> 
> TODO(rch): figure out how to save the quic version and chlo hash.

Actually, not LGTM. This does not include v31 changes to the chromium specific
proof source and verifier.

Powered by Google App Engine
This is Rietveld 408576698